Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dorado calls #23

Merged
merged 5 commits into from
Oct 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ lib
*egg*
dist
__pycache__
NOTES.md
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
numpy
pyslow5>=1.1.0
ont-pyguppy-client-lib==6.5.7
ont-pyguppy-client-lib==7.1.4
14 changes: 12 additions & 2 deletions src/buttery_eel.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ def start_guppy_server_and_client(args, server_args):
# "--max_queued_reads", args.max_queued_reads,
# "--chunk_size", args.chunk_size,
])
params = {"priority": PyGuppyClient.high_priority}
# the high priority queue uses a different batch size which alters the basecalls when called with dorado
# leaving this on default should set it to medium and give 'correct' results
# funny enough, it will call R9.4.1 data at higher accuracy, and the opposite impact on R10.4.1
# params = {"priority": PyGuppyClient.high_priority}
params = {}

if args.moves_out:
params["move_and_trace_enabled"] = True
Expand Down Expand Up @@ -520,7 +524,13 @@ def submit_read(args, iq, rq, address, config, params, N):
if len(calls) > 1:
split_reads = True
for call in calls:
# print(call)
# for i in call:
# if isinstance(call[i], dict):
# for j in call[i]:
# print("{}: {}".format(j, call[i][j]))
# else:
# print("{}: {}".format(i, call[i]))
# sys.exit()
try:
bcalled_read = {}
bcalled_read["sam_record"] = ""
Expand Down
Loading