Skip to content

Commit

Permalink
runtime: skip TestGdbCoreSignalBacktrace on arches other than 386/amd64
Browse files Browse the repository at this point in the history
For golang#25218.

Change-Id: I4024a2064e0f56755fe40eb7489ba28eb4358c60
Reviewed-on: https://go-review.googlesource.com/c/go/+/479518
Run-TryBot: Michael Pratt <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Auto-Submit: Michael Pratt <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
  • Loading branch information
prattmic authored and johanbrandhorst committed Mar 28, 2023
1 parent 15b5cb1 commit 76b35fb
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/runtime/runtime-gdb_unix_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ func TestGdbCoreSignalBacktrace(t *testing.T) {
// to know how to enable/find core files on each OS.
t.Skip("Test only supported on Linux")
}
if runtime.GOARCH != "386" && runtime.GOARCH != "amd64" {
// TODO(go.dev/issue/25218): Other architectures use sigreturn
// via VDSO, which we somehow don't handle correctly.
t.Skip("Backtrace through signal handler only works on 386 and amd64")
}

checkGdbEnvironment(t)
t.Parallel()
Expand Down

0 comments on commit 76b35fb

Please sign in to comment.