-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: /help, /me, and /p commands can't work in non-English languages #3039
base: general-devel
Are you sure you want to change the base?
Conversation
Solve #2914 |
Could someone review this PR? |
Can someone else look at this too? |
This is requesting the enUS locale as set earlier
I guess the |
I would, but I don't understand the issue very well.. Can you ELI5 what is wrong? |
Terraria will translate chat commands into command id. TShock translate them back to keep the command working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and can confirm that it works as intended
When TShock runs in a non-English language, vanilla commands prefix will be localized.
eg.(Chinese)
/help
(English command prefix) =>/帮助
(Chinese command prefix)TShock.OnChat
cannot correctly handle vanilla command prefixese.g.(Chinese) When a player use
/help
, TShock will execute/帮助
(causing the command to not be found).This PR add
EnglishLanguage.GetCommandPrefixByName
to get English vanilla command prefix.