fix: major performance issues with bytea performance brianc#2240

PruvoNet · Jun 19, 2020 · 89758ce · 89758ce
1 parent 316b119
commit 89758ce
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/pg-protocol/src/parser.ts b/packages/pg-protocol/src/parser.ts
@@ -150,14 +150,14 @@ export class Parser {
       this.remainingBufferLength = 0
       this.remainingBufferOffset = 0
     } else {
+      this.remainingBufferLength = fullLength - offset
       if (reuseRemainingBuffer) {
         // Adjust the cursors of remainingBuffer
-        this.remainingBufferLength = combinedBufferLength - offset
-        this.remainingBufferOffset += offset
+        this.remainingBufferOffset = offset
       } else {
-        // To avoid side effects, copy the remaining part of the new buffer to remainingBuffer
-        this.remainingBuffer = combinedBuffer.slice(offset)
-        this.remainingBufferLength = this.remainingBuffer.byteLength
+        // To avoid side effects, copy the remaining part of the new buffer to remainingBuffer with extra space for next buffer
+        this.remainingBuffer = Buffer.allocUnsafe(combinedBufferLength * 2)
+        combinedBuffer.copy(this.remainingBuffer, 0, offset)
         this.remainingBufferOffset = 0
       }
     }