Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more cpu clock options in emuThree #2363

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

yippeeeyay
Copy link

@yippeeeyay yippeeeyay commented Dec 2, 2024

User description

What does this PR do

Adds more cpu clock options in emuThree. Right now it's only 100, 200, 300, or 400%.

Where should the reviewer start

How should this be manually tested

Setting the cpu clock to a lower speed and running a game (20% seems to work the best). It should have higher performance

Any background context you want to provide

Lowering the cpu clock can significantly improve performance and is possible in emuThree and Folium. I have also added the description for cpu clock speed from Citra because it explains how it can cause freezes.

What are the relevant tickets

Screenshots (important for UI changes)

Questions


PR Type

enhancement


Description

  • Expanded the range of CPU clock speed options in emuThree to include more granular settings from 5% to 90% and additional overclocking options at 125% and 150%.
  • Updated the description for CPU clock settings to inform users about the potential impact on game performance and stability.

Changes walkthrough 📝

Relevant files
Enhancement
PVEmuThreeCoreOptions.swift
Expand CPU clock options and update descriptions                 

Cores/emuThree/PVEmuThreeCore/Core/PVEmuThreeCoreOptions.swift

  • Added new CPU clock speed options ranging from 10% to 90%.
  • Updated the description for CPU clock options to include potential
    performance impacts.
  • +16/-1   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Lowering the cpu clock can significantly improve performance and is possible in emuThree and Folium. I have also added the description for cpu clock speed from Citra because it explains how it can cause freezes.
    Copy link

    qodo-merge-pro bot commented Dec 2, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Performance Risk
    The addition of very low CPU clock speeds (5-15%) could make games unplayable. Consider setting a higher minimum threshold or adding a warning for extremely low values.

    Default Value
    No default value is explicitly set for the CPU clock speed option. Consider specifying a safe default value to prevent potential issues.

    Copy link

    qodo-merge-pro bot commented Dec 2, 2024

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    ✅ Remove extremely low CPU clock options that could cause system instability
    Suggestion Impact:The commit removed the 5% CPU clock option, aligning with the suggestion to eliminate extremely low CPU clock values to prevent system instability.

    code diff:

    -                        .init(title: "5%", description: "5%", value: 5),

    Set a reasonable minimum CPU clock value (e.g., 25% or 50%) to prevent system
    instability and game crashes. Very low CPU clock values like 5% are likely to cause
    severe issues.

    Cores/emuThree/PVEmuThreeCore/Core/PVEmuThreeCoreOptions.swift [39-42]

    -.init(title: "5%", description: "5%", value: 5),
    -.init(title: "10%", description: "10%", value: 10),
    -.init(title: "15%", description: "15%", value: 15),
    -.init(title: "20%", description: "20%", value: 20),
    +.init(title: "50%", description: "50%", value: 50),
    +.init(title: "60%", description: "60%", value: 60),
    +.init(title: "70%", description: "70%", value: 70),
    +.init(title: "80%", description: "80%", value: 80),
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Extremely low CPU clock values (5-20%) could lead to severe system instability and game crashes. The suggestion to set a higher minimum threshold is crucial for maintaining system stability and preventing potential user frustration.

    9

    💡 Need additional feedback ? start a PR chat

    I removed the 5%, 15%, 25% etc. cpu clock options that I added and just kept it down to increments of 10. This makes the list of options smaller
    Copy link
    Contributor

    @proskd proskd left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    looks good to me, but I'm not able to test this since emuThree usually doesnt' build for me. @JoeMatt maybe you can test to see the effect?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants