Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] VisualBoyAdvanced enable GameBoy mode #2060

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

[WIP] VisualBoyAdvanced enable GameBoy mode #2060

wants to merge 3 commits into from

Conversation

JoeMatt
Copy link
Member

@JoeMatt JoeMatt commented Dec 10, 2022 •
edited
Loading

VisualBoyAdvanced enable GameBoy mode.

Status:

Draws white screen, but doesn't crash!

Todo:

VBA is a small C core, may make sense to upgrade it first.

@JoeMatt JoeMatt requested a review from jasarien as a code owner December 10, 2022 22:36
@JoeMatt JoeMatt marked this pull request as draft December 10, 2022 22:36
@ghost
Copy link

ghost commented Dec 10, 2022 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@JoeMatt JoeMatt added core: VisualBoyAdvance isolated to Gameboy Boy Advance (GBA) core: VisualBoyAdvance (unless paired) system-GB regarding Nintendo Game Boy [non-core specific] system-GBA regarding Nintendo Game Boy Advance [non-core specific] system-GBC regarding Nintendo Game Boy Color [non-core specific] labels Dec 10, 2022
@github-actions
Copy link

Builds for this Pull Request are available at
Provenance.ipa
Have a nice day.

@JoeMatt
closes #924 Allow VBA to run GB/GBC games
b8cb573 
Signed-off-by: Joseph Mattello <[email protected]>

vba: refactor to 2 targets

Signed-off-by: Joseph Mattello <[email protected]>

Add VBA-Next source files

Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
vba: add vbam-libretro submodule
fcae66e 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
vba: add vba-next submodule
5d2235f 
Signed-off-by: Joseph Mattello <[email protected]>

vba: vba-next module fix

Signed-off-by: Joseph Mattello <[email protected]>

vba: add vba-next submodule

Signed-off-by: Joseph Mattello <[email protected]>

vba: vba-next module fix

Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt JoeMatt force-pushed the feature/VisualBoyAdvance-Enable-GameBoy branch from 254b181 to 5d2235f Compare December 12, 2022 04:54
@github-actions
Copy link

Builds for this Pull Request are available at
Provenance.ipa
Have a nice day.

@JoeMatt JoeMatt changed the title VisualBoyAdvanced enable GameBoy mode [WIP] VisualBoyAdvanced enable GameBoy mode May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasarien jasarien Awaiting requested review from jasarien jasarien is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
core: VisualBoyAdvance isolated to Gameboy Boy Advance (GBA) core: VisualBoyAdvance (unless paired) system-GB regarding Nintendo Game Boy [non-core specific] system-GBA regarding Nintendo Game Boy Advance [non-core specific] system-GBC regarding Nintendo Game Boy Color [non-core specific]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoeMatt