Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] yarn conversion #766

Merged
merged 4 commits into from
Oct 10, 2023
Merged

[Feature] yarn conversion #766

merged 4 commits into from
Oct 10, 2023

Conversation

onetrickwolf
Copy link
Collaborator

Motivation

Fixes some react mismatch bugs with npm workspaces.

Generally preferred by team, was originally removed due to linking bug that no longer exists.

@onetrickwolf onetrickwolf requested a review from Pauan October 10, 2023 20:01
@onetrickwolf onetrickwolf marked this pull request as ready for review October 10, 2023 20:01
Pauan
Pauan approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@Pauan Pauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it.

@onetrickwolf onetrickwolf merged commit 0316240 into testnet3 Oct 10, 2023
1 check passed
@onetrickwolf onetrickwolf deleted the feature/yarn-conversion branch October 10, 2023 20:18
@iamalwaysuncomfortable iamalwaysuncomfortable mentioned this pull request Oct 16, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pauan Pauan Pauan approved these changes

@iamalwaysuncomfortable iamalwaysuncomfortable Awaiting requested review from iamalwaysuncomfortable

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onetrickwolf @Pauan