Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined varint for SizeOf and Write #110

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Conversation

Karang
Copy link
Contributor

@Karang Karang commented Jul 11, 2020

callType() have a different order of parameter depending on the type of compiler (Read, Sizeof, Write) Ultimately we want to change that so the type is always the first parameter and the other parameters have default values, but that require many changes in many projects (protodef, node-minecraft-protocol, prismarine-nbt). This is a simpler fix.

@rom1504 rom1504 merged commit 28ceb35 into ProtoDef-io:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants