add removeType

[rom1504]

Implementation : proto.types[type]=undefined

[SuperOP535]

Shouldn't it be delete proto.types[type]; to actually remove it from the types object

[rom1504]

why do you need to remove a type ?

…

On Mon, Nov 12, 2018 at 10:46 AM SuperOP535 ***@***.***> wrote: Shouldn't it be delete proto.types[type]; to actually remove it from the types object — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#75 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACPN_uwdoSEdQEZcfPrnivM1MuhqSM5wks5uuUOAgaJpZM4JgJu4> .

[SuperOP535]

I don't have to, just wondering why you did = undefined;

[rom1504]

Ah, that's equivalent to remove in js.

…

On Thu, Nov 15, 2018, 11:18 SuperOP535 ***@***.***> wrote: I don't have to, just wondering why you did = undefined; — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#75 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACPN_mbECdMLIIN-bIIWrTTRNi6WBublks5uvT9rgaJpZM4JgJu4> .

[SuperOP535]

const obj = {a: 1, b: 1};
obj.b = undefined;
console.log(obj.hasOwnProperty('b')); // true

delete obj.b;
console.log(obj.hasOwnProperty('b')); // false

Setting it to undefined doesn't actually remove it.