This repository has been archived by the owner on May 9, 2023. It is now read-only.
Refactor, cleanup and doc #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subgrounds.client: - Add docstrings - Remove dead code - Remove unneeded imports
subgrounds.client: - Add docstrings subgrounds.dataframe_utils: - Add docstrings subgrounds.pagination: - Add docstrings - Remove unused `flatten` function - Rename `ArgGeneratorFSM` class to `Cursor` subgrounds.query: - Add docstrings - Rename `Selection.add_selections` to `Selection.add` - Remove `Selection.add_selection` (now handled by `Selection.add`) - Rename `Selection.remove_selections` to `Selection.remove` - Remove `Selection.remove_selection` (now handled by `Selection.remove`) - Rename `Selection.consolidate` to `Selection.merge` - Add recursive flag to `Selection.contains_argument` - Change `Selection.get_argument` return type from `Optional[Argument]` to `Argument` (now raises exception instead of returning None) - Change `Selection.get_argument_by_variable` return type from `Optional[Argument]` to `Argument` (now raises exception instead of returning None) - Change `Selection.substitute_arg` to non-static method - Rename `Query.add_selections` to `Query.add` - Remove `Query.add_selection` (now handled by `Query.add`) - Rename `Query.remove_selections` to `Query.remove` - Remove `Query.remove_selection` (now handled by `Query.remove`) - Change `Query.contains_selection` to non-static method - Remove unused function `input_value_of_string` - Remove unused function `input_value_of_value` - Remove unused function `add_object_field` - Remove unused function `selection_of_path` - Remove unused function `pagination_args` subgrounds.schema: - Edit docstrings subgrounds.subgraph: - Add dosctrings subgrounds.subgrounds: - Add dosctrings subgrounds.transform: - Add dosctrings subgrounds.utils: - Add dosctrings tests: - Adapt tests to changes misc: - Remove unused `types.py` module
cvauclair
added
documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes