Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use approx for x > 1.0 in elliptic integrals #53

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Only use approx for x > 1.0 in elliptic integrals #53

merged 1 commit into from
Dec 12, 2024

Conversation

bclyons12
Copy link
Member

No description provided.

@bclyons12 bclyons12 added the bug Something isn't working label Dec 12, 2024
@bclyons12 bclyons12 requested a review from orso82 December 12, 2024 01:27
@bclyons12 bclyons12 self-assigned this Dec 12, 2024
@bclyons12
Copy link
Member Author

@orso82 This fixes the regressions. Can you make sure it solves the problem you were having that the isapprox was an attempt to solve? If so, then we can merge and release a patch.

@orso82 orso82 merged commit b8719d5 into master Dec 12, 2024
2 checks passed
@orso82 orso82 deleted the fix_elliptic branch December 12, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orso82 orso82 Awaiting requested review from orso82

Assignees

@bclyons12 bclyons12

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bclyons12 @orso82