v2.0.1 Adding back read_b2_boundary_parameters #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was removed in 0d2ef6b to remove unregistered Fortran90Namelists dep. The usecase of reading the namelist was very specific, so this commit adds a small basic julia funciton to read the required parts of namelist and adds back this function. In future, if generic fortran namelist parser is available in Julia Registry, we will use that.
anchal-physics
force-pushed
the
add_back_boundary_param_read
branch
from
eaf9e07 to
db40748
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was removed in 0d2ef6b to remove unregistered Fortran90Namelists dep. The usecase of reading the namelist was very specific, so this commit adds a small basic julia funciton to read the required parts of namelist and adds back this function.
In future, if generic fortran namelist parser is available in Julia Registry, we will use that.