Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading mag field data from b2fgmtry, on by default, add test #43

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

eldond
Copy link
Collaborator

@eldond eldond commented Jul 23, 2024

  • Fixed bug in how magnetic field data from b2fgmtry were added to the IDS
  • Turned on the load_bb option by default
  • Added tests for cases with and without bb data being added

- Fixed bug in how magnetic field data from b2fgmtry were added to the IDS
- Turned on the load_bb option by default
- Added tests for cases with and without bb data being added
@eldond eldond requested a review from anchal-physics July 23, 2024 15:39
@eldond eldond self-assigned this Jul 23, 2024
Copy link
Collaborator

@anchal-physics anchal-physics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@anchal-physics anchal-physics merged commit dc5bff7 into master Jul 23, 2024
3 checks passed
@eldond eldond deleted the bb branch July 23, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants