Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using TPS mats interpolation while projection #43

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

anchal-physics
Copy link
Collaborator

For projection from higher dimension to lower dimension subsets, the function project_prop_on_subset!() whill now use thin plate spline interpolation to project the property values. The matrcies required can be provided as keyword argument in case this function is called multiple times for same grid geometry.

Additionally, get_subset_space had a bug in handling 1-dimensional subsets as it was originally coded to handle 2D and 3D subsets only. This case is now handled.

For projection from higher dimension to lower dimension subsets,
the function project_prop_on_subset!() whill now use thin plate spline
interpolation to project the property values. The matrcies required
can be provided as keyword argument in case this function is called
multiple times for same grid geometry.
@anchal-physics anchal-physics requested a review from eldond April 22, 2024 22:21
Copy link
Contributor

@eldond eldond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks okay. Tests pass after checking out compatible branches in related repos and pulling latest samples from dvc.

@anchal-physics anchal-physics merged commit c67eb54 into dev May 1, 2024
1 check passed
@eldond eldond deleted the add_tool branch July 24, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants