Add check function for ini.requirements vs constraint functions in optimization #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adrianaghiozzi this is a great addition, as for the TBR I never added it to the requirements as it always be able to get there due to the Li6/Li7 ratio it can change internally. It probably is good to make it an explicit requirement (and maybe we should think if a constraint to the Li7/Li6 ratio perhaps) |
|
I could see having a constraint for a desired Li6/Li7 value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the code camp there was a suggestion to add a check function in the multi-objective optimization setup that ensures that each requirement that is set in ini.requirements also has a constraint function that goes with it. This (+ a supporting PR in IMAS) implements that functionality, giving the user a warning if they set a requirement without setting a constraint function for it.
Doing this also made me realize that we have no constraint function for TBR - is that an oversight or is there some particular reason? @TimSlendebroek