Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer Validation Zone/Offerer #978

Merged
merged 7 commits into from
Feb 14, 2023
Merged

Transfer Validation Zone/Offerer #978

merged 7 commits into from
Feb 14, 2023

Conversation

BCLeFevre
Copy link
Contributor

Motivation

Zone framework for testing an issue with order fulfillment and the timing when our accumulator is triggered in v1.2

Solution

@BCLeFevre BCLeFevre requested review from 0age and DJViau February 14, 2023 03:01
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (bd335ca) compared to base (e99e1e3).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##               1.3      #978   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         2661      2671   +10     
  Branches       393       394    +1     
=========================================
+ Hits          2661      2671   +10     
Flag Coverage Δ
foundry 77.71% <ø> (-0.10%) ⬇️
production 100.00% <ø> (ø)
reference 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/lib/Verifiers.sol 100.00% <0.00%> (ø)
contracts/lib/OrderCombiner.sol 100.00% <0.00%> (ø)
contracts/lib/LowLevelHelpers.sol 100.00% <0.00%> (ø)
contracts/lib/ConsiderationBase.sol 100.00% <0.00%> (ø)
contracts/lib/FulfillmentApplier.sol 100.00% <0.00%> (ø)
reference/lib/ReferenceOrderCombiner.sol 100.00% <0.00%> (ø)
reference/lib/ReferenceConsiderationBase.sol 100.00% <0.00%> (ø)
reference/lib/ReferenceFulfillmentApplier.sol 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BCLeFevre BCLeFevre changed the title First commit Transfer Validation Zone/Offerer Feb 14, 2023
Copy link
Contributor

@DJViau DJViau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened a PR with a tiny bit of cleanup here.

Great work, thanks for knocking this out in such short order.

…n-ben/ZoneContractOrderValidator

linting, cleanup, and a tiny refactor
@DJViau DJViau changed the base branch from main to 1.3 February 14, 2023 15:38
@0age 0age merged commit 4c3a4de into 1.3 Feb 14, 2023
@0age 0age deleted the ben/ZoneContractOrderValidator branch February 14, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants