-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer Validation Zone/Offerer #978
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## 1.3 #978 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 2661 2671 +10
Branches 393 394 +1
=========================================
+ Hits 2661 2671 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened a PR with a tiny bit of cleanup here.
Great work, thanks for knocking this out in such short order.
…n-ben/ZoneContractOrderValidator linting, cleanup, and a tiny refactor
Motivation
Zone framework for testing an issue with order fulfillment and the timing when our accumulator is triggered in v1.2
Solution