Add transfer helper #480
Merged
Add transfer helper #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuckinaboot
approved these changes
Jun 9, 2022
0age
approved these changes
Jun 10, 2022
axic
reviewed
Jun 11, 2022
| } | ||
|
|
||
| // Call the conduit and execute bulk transfers. | ||
| ConduitInterface(conduit).execute(conduitTransfers); |
There was a problem hiding this comment.
There is no validation this returns the magic, so solely TransferHelper depends on setup correctly with a valid conduit.
There was a problem hiding this comment.
Actually this piece doesn't even use the conduitController, but derives an address from from the key. So as long as returndata is returned this is considered successful. Should really check the magic.
There was a problem hiding this comment.
and/or should perform the same check the ConduitController is doing: conduit.codehash == _CONDUIT_RUNTIME_CODE_HASH.
axic
reviewed
Jun 11, 2022
| else { | ||
| // Derive the conduit address from the deployer, conduit key | ||
| // and creation code hash. | ||
| address conduit = address( |
There was a problem hiding this comment.
I wonder if it would make sense instead having a public function for this on the conduit, though that has a call cost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a helper contract to allow bulk transfers of ERC20/ERC721/ERC1155 to a specified recipient.
Solution
TransferHelper.sol,TransferHelperInterface.sol, andTransferHelperStructs.sol