Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dan/2023/05/wrap make address #1236

Merged
merged 4 commits into from
May 11, 2023

Conversation

DJViau
Copy link
Contributor

@DJViau DJViau commented May 11, 2023

Because forge's makeAccount is internal and we need to use it in libraries, we need to make a public wrapper for it :(

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d09a41b) 99.96% compared to head (80736cc) 99.96%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           ryan/update-forge-std    #1236   +/-   ##
======================================================
  Coverage                  99.96%   99.96%           
======================================================
  Files                         47       47           
  Lines                       2689     2689           
  Branches                     396      396           
======================================================
  Hits                        2688     2688           
  Misses                         1        1           
Flag Coverage Δ
foundry 78.08% <ø> (+0.04%) ⬆️
production 100.00% <ø> (ø)
reference 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DJViau DJViau merged commit 61c798a into ryan/update-forge-std May 11, 2023
@DJViau DJViau deleted the dan/2023/05/wrap-make-address branch May 11, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants