Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/issue 30 apply bold font family to key home page headings #85

Merged
merged 3 commits into from
Sep 20, 2024
Merged

enhancement/issue 30 apply bold font family to key home page headings #85

merged 3 commits into from
Sep 20, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Sep 2, 2024 •
edited
Loading

Related Issue

#30

Summary of Changes

In #84 I realized why the bolded fonts weren't working, so this is intended to apply them once that PR lands

  1. Apply bolded font to key home page sections
  2. Cleaning up the font-weight in the heading / navigation helped fix header navigation rollover is glitchy in Safari / FF #90

TODO

  1. Rebase against main once feature/issue 34 blog landing page and all posts #84 is merged
  2. Remove all instances of font-weight: bold and replace with font-family: var(--font-primary-bold)
  3. Responsiveness checks

@thescientist13 thescientist13 added the enhancement New feature or request label Sep 2, 2024
@thescientist13 thescientist13 changed the title apply bold font family to the home page enhancement/issue 30 apply bold font family to key home page headings Sep 2, 2024
@thescientist13 thescientist13 linked an issue Sep 2, 2024 that may be closed by this pull request
Home Page #30
Closed
7 tasks
@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit f86f094
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/66eda259d576c10008cc0a4b
😎 Deploy Preview https://deploy-preview-85--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 force-pushed the enhancement/issue-30-home-page-font-bolding branch from 8ec09b3 to 1002a62 Compare September 5, 2024 19:21
@thescientist13 thescientist13 marked this pull request as ready for review September 5, 2024 19:23
@thescientist13 thescientist13 force-pushed the enhancement/issue-30-home-page-font-bolding branch from b342955 to f86f094 Compare September 20, 2024 16:27
@thescientist13 thescientist13 merged commit 65dfc1d into main Sep 20, 2024
5 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-30-home-page-font-bolding branch September 20, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
[Greenwood] Website Redesign and Relaunch
Status: ✅ Done
Milestone
Website Redesign and Relaunch
Development

Successfully merging this pull request may close these issues.

header navigation rollover is glitchy in Safari / FF Home Page
1 participant
@thescientist13