Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/issue 144 best practices and recommendations for import maps and referencing node modules #153

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 16, 2024

Related Issue

resolves #144

Summary of Changes

  1. Update docs around Import Maps implementation details and ecosystem compatibility
  2. Improve Script and Styles docs for best practices regarding using bare and relative specifiers and the "shortcut" alias for referencing /node_modules based paths
  3. Add Lit component library demos link to the Lit ecosystem page
  4. Demonstrate helper utilities in Copy Plugin docs

TODO

  1. Plugins Docs
  2. Final draft review
    • make sure shortcase alias is documented as not being an option for ESM (at least for SSR?)

@thescientist13 thescientist13 added the docs Greenwood specific content like docs and guides label Dec 16, 2024
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit 6fee75f
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/67607ae88595d800089328c3
😎 Deploy Preview https://deploy-preview-153--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 changed the title Docs/issue 144 best practices and recommendations for import maps and referencing node modules docs/issue 144 best practices and recommendations for import maps and referencing node modules Dec 16, 2024
@thescientist13 thescientist13 marked this pull request as ready for review December 16, 2024 19:10
@import "../../node_modules/open-props/src/props.fonts.css";
@import "../../node_modules/open-props/src/props.shadows.css";
@import "../../node_modules/open-props/src/props.sizes.css";
@import "../../]node_modules/open-props/borders.min.css";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@import "../../] - typo alert!

@thescientist13 thescientist13 marked this pull request as draft December 30, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Greenwood specific content like docs and guides release/v0.31.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve documentation around referencing scripts, styles, and import map diagnostics
1 participant