Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/use getRootNode for this references in JSX DSD #131

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jan 4, 2024

Related Issue

resolves #109

See an example here

Summary of Changes

  1. Leverage getRootNode for this references inside DSD generated by JSX

This should be merged after #129 since that PR adds a missing test case and does a fair amount of refactoring

@thescientist13 thescientist13 added enhancement Improvement to existing functionality JSX labels Jan 4, 2024
@thescientist13 thescientist13 force-pushed the enhancement/issue-109-get-root-node-reference-for-jsx branch from d03ecad to 0d6be88 Compare January 6, 2024 18:43
@thescientist13 thescientist13 merged commit 0bb1fa8 into master Jan 6, 2024
12 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-109-get-root-node-reference-for-jsx branch January 6, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality JSX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

leverage getRootNode() for referencing Shadow DOM based parent node reference in JSX output
1 participant