-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/0.26.0 #956
Merged
Merged
release/0.26.0 #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial working local development example with wc-compiler for SSR native HTMLElement * restore getTemplate to original location in SSR route worker * bump latest version of wcc * ensure passing of URLs to wcc * upgrade WCC * add support for prerendering SSR routes with default renderer WCC in favor of puppeteer * document default export * clean up console logging * rollback premature static export feature * use WCC to bundle SSR page routes automatically * roll back native SSR auto hydration * LitElement as SSR page with default export * LitElement as a default export for pages * clarify README example * capture Lit exception for light DOM support
thescientist13
added
documentation
Greenwood specific docs
Plugins
Greenwood Plugins
CLI
breaking
SSR
v0.26.0
labels
Jul 1, 2022
thescientist13
changed the title
Feature/issue 935 native custom element ssr (#943)
release/0.26.0
Jul 1, 2022
5 tasks
* add DSD polyfill and refactor for options * feature detect for DSD polyfill
5 tasks
5 tasks
* working version of SSR static export * update comment * document static SSR export * refactor and TODOs * break pass by reference
5 tasks
* puppeteer renderer plugin and migrate resource plugin * introduce custom function option for renderer plugins and moved puppeteer logic into plugin * made WCC default prerender * stabilize specs * upgrade latest version of puppeteer * add specs for puppeteer renderer plugin * clarify it block * stablize all CLI specs * fix spelling mistake * comments for init specs * restore graphql specs with dependency on puppeteer plugin when prerendering * restore all specs and adjust thresholds * misc PR cleanup * fix lint and clean up package jsons * fix lint and clean up package jsons * upgrade latest version of WCC * update docs to reflect prerendering with WCC and cross dependencies with Puppeteer * fix and restore puppeteer based inline javascript execution specs * fix typo in specs * cross platform puppeteer intercepting support * refactor preRenderCompilationWorker to be async Promise.all
* fixed import commonjs plugin named export * fix misc spelling mistakes in comments
OK, aside from documentation and blog post content, this technically ready and tested. 🙌 |
This was referenced Jul 19, 2022
Merged
* update getting started guide and about sections with introduction of WCC * move puppeteer specific caveats to puppeteer plugin README * remove errant character * misc grammar and editing
* first draft of v0.26.0 blog post * quick grammar fix * remove extraneous character * misc edits and revisions
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
HTMLElement
#935HTMLElement
(WCC) as default renderer #954export
is spelled wrong 🤦 #961Summary of Changes
default export
)HTMLElement
(WCC) as default rendering optionAlpha Release Test Plan
I think to be safe given the level of refactoring, would like to at least make sure this get tested with a few key repos
The plan would be to test against the following projects / workflows as alpha releases are iterated upon:
prerender
instead of puppetter projectevergreen.github.io#88npx
/init
(main test will be afteralpha.1
)TODOs
alpha.0
HTMLElement
(WCC) as default renderer #954alpha.1
Questions / New Issues
<style>
blocks are now left "in place" as it were, in the generated HTML, as opposed to serialized into the<head>
using ShadyCSS I believe. This is a mistake on my part since I probably shouldn't have been using Shadow DOM for static content anyway, but perhaps there is a way to retain that conventions since having as much of the global CSS in the<head>
would be ideal.export default
, should find a way to get the tag name automatically, or maybe we don't need it all?