-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 709 custom render plugin #869
Feature/issue 709 custom render plugin #869
Conversation
…upport for plugins
…cit SSR output for lit renderer
Good catch on the call @hutchgrant 🔍 👀 I was trying to be a bit too clever maybe by having an option for SSR routes to be rendered by a custom renderer (e.g. Lit) AND also puppeteer, but that seems excessive since the whole point of a custom renderer is to avoid that overhead. Puppeteer was basically giving us its own HTML instead of the nice HTML that Lit gave us with declarative shadow DOM and all the nice hydration markers. Verified it works as expected now and also updated that spec to test the affirmative (explicit name matches) as opposed for testing the negative (absence of default placeholder text). Thanks! 🤝 |
* POC of Lit SSR for development * render lit SSR from html * add renderer API to Greenwood * mini refactor * stub out lit renderer plugin * build and serve support * update specs * fix incorrect callback assignment * refactor SSR worker for Greenwood as a plugin * support for intercepting and optimizing SSR routes and add dual SSR support for plugins * template support for SSR routes * set prerender true in spec * add minimumal support for using custom renderer to prerender static pages * lit render SSR specs * address spec TODOs * fix specs * SSR specs for development * documentation for custom renderer plugin * remove puppeteer prerendering option from SSR routes and ensure explicit SSR output for lit renderer * remove demo code
Related Issue
#709 / #710
Summary of Changes
TODO
Thoughts / Questions