Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better import CSS detection for browsers #483

Merged
merged 2 commits into from
Mar 5, 2021
Merged

better import CSS detection for browsers #483

merged 2 commits into from
Mar 5, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 25, 2021 •
edited
Loading

Related Issue

resolves #482

firefox-import-css

safari-import-css

Summary of Changes

  1. Switched to using accept headers to tell if CSS is not being requested via <style> tag and using import / fetch instead

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP Plugins Greenwood Plugins labels Feb 25, 2021
@thescientist13 thescientist13 linked an issue Feb 25, 2021 that may be closed by this pull request
plugin-import-css not working in (non Chrome) browsers like Safari and Firefox (v0.10.0 alpha) for develop #482
Closed
5 tasks
@thescientist13 thescientist13 merged commit b98aee1 into release/0.10.0 Mar 5, 2021
@thescientist13 thescientist13 deleted the bug/issue-482-improve-import-css-detection branch March 5, 2021 22:24
@thescientist13 thescientist13 mentioned this pull request Mar 21, 2021
Closed
5 tasks
thescientist13 added a commit that referenced this pull request Apr 3, 2021
@thescientist13
better import CSS detection for browsers (#483)
c7cb890
thescientist13 added a commit that referenced this pull request Apr 3, 2021
@thescientist13
better import CSS detection for browsers (#483)
47d6ed7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aholtzman aholtzman Awaiting requested review from aholtzman

@hutchgrant hutchgrant Awaiting requested review from hutchgrant

Assignees
No one assigned
Labels
bug Something isn't working P0 Critical issue that should get addressed ASAP Plugins Greenwood Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin-import-css not working in (non Chrome) browsers like Safari and Firefox (v0.10.0 alpha) for develop
1 participant
@thescientist13