Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hoist cssnano to cli package #480

Merged
merged 1 commit into from
Feb 20, 2021
Merged

hoist cssnano to cli package #480

merged 1 commit into from
Feb 20, 2021

Conversation

thescientist13
Copy link
Member

Related Issue

resolves #479

Summary of Changes

  1. Added / hoisted cssnano to @greenwood/cli package where it is getting used for default optimization
% yarn why cssnano
yarn why v1.12.3
[1/4] 🤔  Why do we have the module "cssnano"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
   - "_project_#@greenwood#cli" depends on it
   - Hoisted from "_project_#@greenwood#cli#cssnano"
   - Hoisted from "_project_#@greenwood#plugin-import-css#rollup-plugin-postcss#cssnano"
info Disk size without dependencies: "48KB"
info Disk size with unique dependencies: "1.36MB"
info Disk size with transitive dependencies: "25.89MB"
info Number of shared dependencies: 52
✨  Done in 0.85s.

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI labels Feb 20, 2021
@thescientist13 thescientist13 linked an issue Feb 20, 2021 that may be closed by this pull request
Error: Cannot find module 'cssnano' when running CLI commands (alpha.5) #479
Closed
5 tasks
@thescientist13 thescientist13 merged commit c637988 into release/0.10.0 Feb 20, 2021
@thescientist13 thescientist13 deleted the bug/issue-479-fix-missing-dependency branch February 20, 2021 17:06
thescientist13 added a commit that referenced this pull request Apr 3, 2021
@thescientist13
hoist cssnano to cli package (#480)
a5e8477
thescientist13 added a commit that referenced this pull request Apr 3, 2021
@thescientist13
hoist cssnano to cli package (#480)
c5d20ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'cssnano' when running CLI commands (alpha.5)
1 participant
@thescientist13