Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rfc/issue 355 separate markdown transform #423

Closed
wants to merge 1 commit into from
Closed

Rfc/issue 355 separate markdown transform #423

wants to merge 1 commit into from

Conversation

hutchgrant
Copy link
Member

@hutchgrant hutchgrant commented Oct 26, 2020 •
edited
Loading

Related Issue

#355

Summary of Changes

  • separate markdown transform from html transform
  • put common functions in separate tools library for use for extending the html transform for other things.

TODO

  • does not work properly in production yet. Problem related to resolving markdown file paths based on current route. Needs to check for route/index.md as well as route.md

@thescientist13 thescientist13 added hacktoberfest-accepted RFC Proposal and changes to workflows, architecture, APIs, etc labels Oct 27, 2020
@hutchgrant
Copy link
Member Author

This PR can be closed in favour of work in #422

@hutchgrant hutchgrant closed this Nov 9, 2020
@thescientist13 thescientist13 linked an issue Dec 31, 2020 that may be closed by this pull request
<meta> Component package #304
Closed
5 tasks
@thescientist13 thescientist13 deleted the rfc/issue-355-transforms-markdown branch July 20, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted RFC Proposal and changes to workflows, architecture, APIs, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<meta> Component package
2 participants
@hutchgrant @thescientist13