Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter out index page from children query #388

Merged
merged 5 commits into from
Jul 25, 2020
Merged

filter out index page from children query #388

merged 5 commits into from
Jul 25, 2020

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jul 12, 2020 •
edited
Loading

Related Issue

resolves #332

Summary of Changes

  1. Exclude parent page from getChildrenFromParentRoute call
  2. Update Specs

TODO

  1. Wait until Bug/issue 371 similar query calls invariant error #383 is merged, then remove need to filter here (which should still allow the test to pass and further confirm the implementation here)

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) Content as Data labels Jul 12, 2020
@thescientist13 thescientist13 mentioned this pull request Jul 17, 2020
Merged
@thescientist13 thescientist13 self-assigned this Jul 22, 2020
@thescientist13 thescientist13 force-pushed the enhancement/issue-332-filter-out-parent-from-children-query branch from d39c4de to 8806039 Compare July 22, 2020 00:59
@thescientist13
Copy link
Member Author

thescientist13 commented Jul 22, 2020 •
edited
Loading

Hmm I wonder if there's a bug here as this is failing now after getting upgraded with master.

  557 passing (7m)
  1 failing

  1) Build Greenwood With: 
       Data from GraphQL
         Blog Page (Template) w/ Navigation and Children Query
           should have expected blog posts links in the <body> tag when using ChildrenQuery:

      AssertionError: expected 0 to equal 2
      + expected - actual

      -0
      +2
      
      at Context.<anonymous> (packages/cli/test/cases/build.data.graph/build.data.graph.spec.js:169:40)

Might be related to ChildrenQuery and variables since Graph query in the header seems to be fine?

@thescientist13 thescientist13 added the help wanted Extra attention is needed label Jul 22, 2020
@thescientist13 thescientist13 removed the help wanted Extra attention is needed label Jul 22, 2020
@thescientist13 thescientist13 removed their assignment Jul 22, 2020
@thescientist13
Copy link
Member Author

All set now 👍

@thescientist13
remove index filter
b7107f7
@thescientist13
Merge branch 'enhancement/issue-332-filter-out-parent-from-children-q…
ef894d5 
…uery' of github.com:ProjectEvergreen/greenwood into enhancement/issue-332-filter-out-parent-from-children-query
@thescientist13 thescientist13 merged commit 2a6238e into master Jul 25, 2020
@thescientist13 thescientist13 deleted the enhancement/issue-332-filter-out-parent-from-children-query branch July 25, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutchgrant hutchgrant Awaiting requested review from hutchgrant

Assignees
No one assigned
Labels
Content as Data enhancement Improve something existing (e.g. no docs, new APIs, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filter out parent page from ChildrenQuery response
1 participant
@thescientist13