-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make cache file writing sync and hashed by query #346
Changes from all commits
cf448d3
d6d5117
3413d71
c9890a5
9a7bd27
b1ea399
8f3a7ed
a73b12d
2c38015
6df727a
c564305
c6437e3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,8 @@ class PageTemplate extends LitElement { | |
this.route = ''; | ||
} | ||
|
||
updated() { | ||
connectedCallback() { | ||
super.connectedCallback(); | ||
this.route = window.location.pathname; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My understanding is this lifecycle is run after the component has been rendered. I tested using the connectedCallback() to set the this.page variable from the page-template and had better results (I wasn't able to break it). Maybe that's just chance, I don't know. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking I would even like to go so further as to just pass the full route from the page-template.js, then the shelf would have access to the full path via "props", and that could be used here instead of
window.location.pathname
).Just could help keep the shelf a little more self contained.