Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Technical/issue 193 decouple puppeteer polyfill plugin dependency #206

Merged
merged 7 commits into from
Sep 26, 2019
Merged

Technical/issue 193 decouple puppeteer polyfill plugin dependency #206

merged 7 commits into from
Sep 26, 2019

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Sep 21, 2019 •
edited
Loading

Related Issue

resolves #193

Summary of Changes

It's quick and dirty but keeps polyfills distinct between the two browser environments (Chromium and the user).

  1. Removing Polyfill Plugin as a hard dependency of the CLI (however, Chromium still needs it) by adding / removing it for serialiazation step
  2. Added PolyFill Plugin to greenwood.config.js for the website
  3. Update dependencies
  4. Refactored serialization lifecycle to better manage the file writing all in one place. (could make the argument browser and renderer could also be consolidated, but will worry about that another time 😄 )

TODO

  1. Would like to see if I can have all the string replace stuff all happen in serialize the lifecycle only, but that requires knowing each index.html path

@thescientist13 thescientist13 added chore unit testing, maintenance, etc Plugins Greenwood Plugins labels Sep 21, 2019
@thescientist13 thescientist13 changed the title Technical/issue 193 decouple puppeteer oolyfill plugin dependency Technical/issue 193 decouple puppeteer polyfill plugin dependency Sep 21, 2019
@thescientist13 thescientist13 self-assigned this Sep 26, 2019
@thescientist13 thescientist13 merged commit 019b68e into release/0.4.0 Sep 26, 2019
@thescientist13 thescientist13 deleted the technical/issue-193-decouple-puppeteer-oolyfill-plugin-dependency branch September 26, 2019 00:01
thescientist13 added a commit that referenced this pull request Oct 16, 2019
@thescientist13
Technical/issue 193 decouple puppeteer polyfill plugin dependency (#206)
e4d2ed9 
* polyfill just puppeteer

* decouple plugin from cli

* dependency refactoring

* add polyfill plugin to website

* add polyfill plugin to website

* formatting

* serlialization refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutchgrant hutchgrant Awaiting requested review from hutchgrant

Assignees

@thescientist13 thescientist13

Labels
chore unit testing, maintenance, etc CLI Plugins Greenwood Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13