Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/issue 187 polyfills plugin #195

Merged
merged 13 commits into from
Sep 21, 2019

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Sep 16, 2019

Related Issue

resolves

Summary of Changes

  1. Created a Polyfills Plugin - currently enabled by default for now, will follow up as part of Polyfills plugin should feature detect polyfills support (using webcomponents loader) #9 and decouple polyfills for serialization from polyfills needed for users #193
  2. Refactored Babel transpilation implementation to be based on modern @babel/preset-env configuration (@babel/polyfills deprecated)
  3. Pulling webcomponents from npm now - have polyfills in index.html managed as npm dependencies #178
  4. Upgraded to postcss-preset-env - postcss-cssnext has been deprecated #140
  5. IE11 supported by default (though somewhat broken in places - see TODOs)
  6. Created some How It Works and Browser support docs
  7. Since polyfills from node_modules are required for now, adjusted TestBed to support this hard dependency
  8. Misc contributor documentation for IE testing
  9. Fixed hooks naming convention
  10. Better documentation for Plugin APIs

TODO

  1. Hmm.. tests are passing locally 🤔 re ran the build in CircleCI and everything passed ✅
  2. Document config and context usage in docs
  3. There are minor bugs with IE11 / Edge that I need to open, otherwise site looks good!
  4. This definitely helped bring bundle sizes down a little and improve lighthouse (though we can definitely do better). Will run Lighthouse and hopefully [RFC] Route Based Code Splitting #136 will help with our initial payload sizes being larger than I would like. Will probably make a ticket for that too, or update the description of the code splitting ticket. Updated Code Splitting description ✅
  5. Will be good to discuss Polyfills plugin should feature detect polyfills support (using webcomponents loader) #9 and decouple polyfills for serialization from polyfills needed for users #193 during our weekly call

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) website Tasks related to the projects website / documentation documentation Greenwood specific docs Plugins Greenwood Plugins labels Sep 16, 2019
@thescientist13 thescientist13 self-assigned this Sep 16, 2019
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the initial build failure and subsequent passing by just re-running the build, going to see if re-running the build a few more times corroborates any particular outcome. One thought is that I introduced more sync based file operations as part of TestBed so maybe Node had a bit of an issue? I know often times the NodeJS docs say to use use the async (default) versions of these fs methods.

Anyway, will run it 3 more times and see what it's like. Could just be a one-off that occurs sometimes like any sort of system / networking / etc.

@thescientist13
Copy link
Member Author

Reran the build three more times and everything seems to be running fine
Screen Shot 2019-09-18 at 7 40 10 AM

@thescientist13 thescientist13 merged commit cae49c5 into release/0.4.0 Sep 21, 2019
@thescientist13 thescientist13 deleted the enhancement/issue-187-polyfills-plugin branch September 21, 2019 18:23
thescientist13 added a commit that referenced this pull request Oct 16, 2019
* remove polyfills from index.html and use @babel/preset-env for polyfilling

* remove polyfills from index.html and use @babel/preset-env for polyfilling

* update comments

* how it works documentation

* switch to postcss preset env

* contributing docs for IE11

* fix unit tests

* polyfill plugin and refactor greenwood/cli with it as dependency

* pull bundle from npm

* remove extra preset

* comment TODO

* update polyfills README

* compilation documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins website Tasks related to the projects website / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant