-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/issue 187 polyfills plugin #195
Enhancement/issue 187 polyfills plugin #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the initial build failure and subsequent passing by just re-running the build, going to see if re-running the build a few more times corroborates any particular outcome. One thought is that I introduced more sync based file operations as part of TestBed
so maybe Node had a bit of an issue? I know often times the NodeJS docs say to use use the async (default) versions of these fs
methods.
Anyway, will run it 3 more times and see what it's like. Could just be a one-off that occurs sometimes like any sort of system / networking / etc.
* remove polyfills from index.html and use @babel/preset-env for polyfilling * remove polyfills from index.html and use @babel/preset-env for polyfilling * update comments * how it works documentation * switch to postcss preset env * contributing docs for IE11 * fix unit tests * polyfill plugin and refactor greenwood/cli with it as dependency * pull bundle from npm * remove extra preset * comment TODO * update polyfills README * compilation documentation
Related Issue
resolves
Summary of Changes
TestBed
to support this hard dependencyTODO
Hmm.. tests are passing locally 🤔re ran the build in CircleCI and everything passed ✅Document✅config
andcontext
usage in docsThere are minor bugs with IE11 / Edge that I need to open, otherwise site looks good!✅develop
This definitely helped bring bundle sizes down a little and improve lighthouse (though we can definitely do better). Will run Lighthouse and hopefully [RFC] Route Based Code Splitting #136 will help with our initial payload sizes being larger than I would like. Will probably make a ticket for that too, or update the description of the code splitting ticket.Updated Code Splitting description ✅Will be good to discuss Polyfills plugin should feature detect polyfills support (using webcomponents loader) #9 and decouple polyfills for serialization from polyfills needed for users #193 during our weekly call✅