Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/issue 186 google analytics plugin #190

Merged
merged 8 commits into from
Sep 11, 2019
Merged

Enhancement/issue 186 google analytics plugin #190

merged 8 commits into from
Sep 11, 2019

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Sep 6, 2019 •
edited
Loading

Related Issue

resolves #186

Summary of Changes

  1. Created a new package @greenwood/plugin-google-analytics
  2. Added tests and README docs
  3. Created a page for Composite Plugins to the Plugins section of the website
  4. Integrated the plugin into the Greenwood website
  5. Added support for Google SEO

As part of #179, would like to determine a more ergonomic API for composite plugins. Maybe just accept an Array directly, and Greenwood and can spread it instead?

TODO

  1. Check GA and make sure it is filtering for only hits from www.greenwoodjs.io
  2. Will probably make an issue for this, but it would be cool if there was a way through a plugin that we could point to a directory of .md files, like in packages/ and make a page out of it and / or put it into the graph so that we can generate the <table> in the Composite Plugins page dynamically.

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) website Tasks related to the projects website / documentation Plugins Greenwood Plugins labels Sep 6, 2019
thescientist13
thescientist13 commented Sep 11, 2019
View reviewed changes
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this should ensure that only hits from www.greenwoodjs.io are counted and localhost or anything ending with *.netlify.com are excluded
Screen Shot 2019-09-10 at 8 43 25 PM

thescientist13
thescientist13 commented Sep 11, 2019
View reviewed changes
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few options for adding Google SEO snippet
Screen Shot 2019-09-10 at 8 52 28 PM

Opted to go with <meta> tag approach
Screen Shot 2019-09-10 at 8 52 35 PM

@thescientist13 thescientist13 merged commit 770e940 into release/0.4.0 Sep 11, 2019
@thescientist13 thescientist13 deleted the enhancement/issue-186-google-analytics-plugin branch September 11, 2019 00:59
thescientist13 added a commit that referenced this pull request Oct 16, 2019
@thescientist13
Enhancement/issue 186 google analytics plugin (#190)
a825471 
* working example with testse

* error handling

* update GA script and specs and integrated into the website

* custom plugins page

* finish docs

* clean up package.json

* anonymous IP tracking

* add Google SEO meta tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutchgrant hutchgrant Awaiting requested review from hutchgrant

Assignees
No one assigned
Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins website Tasks related to the projects website / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13