Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/use Worker threads for full API routes cache busting in development mode #1105

Merged
merged 2 commits into from
May 6, 2023
Merged

bug/use Worker threads for full API routes cache busting in development mode #1105

merged 2 commits into from
May 6, 2023

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented May 1, 2023 •
edited
Loading

Related Issue

resolves #1104

api-routes-full-live-reloading-working.mov

Summary of Changes

  1. Implement Workers based work around for full API routes cache busting in development mode

_Seems to work well enough in a demo repo, not sure if we're missing any other properties, per #1048? _

TODO

  1. Clean up console logs / debug code
  2. Creating tracking ticket (GFI) to put all these JSON stringify / parse functions into a util file (including reviver, etc)

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI SSR labels May 1, 2023
@thescientist13 thescientist13 changed the title use workers for full API routes cache busting in development mode use Worker threads for full API routes cache busting in development mode May 1, 2023
@thescientist13 thescientist13 changed the title use Worker threads for full API routes cache busting in development mode bug/use Worker threads for full API routes cache busting in development mode May 6, 2023
@thescientist13 thescientist13 changed the title bug/use Worker threads for full API routes cache busting in development mode use Worker threads for full API routes cache busting in development mode May 6, 2023
@thescientist13 thescientist13 changed the title use Worker threads for full API routes cache busting in development mode bug/use Worker threads for full API routes cache busting in development mode May 6, 2023
@thescientist13 thescientist13 mentioned this pull request May 6, 2023
Closed
@thescientist13 thescientist13 force-pushed the bug/issue-1104-api-routes-not-fully-reloading-changes-in-dev-mode branch from e49da21 to 6331927 Compare May 6, 2023 13:53
@thescientist13 thescientist13 merged commit 4f7ea8a into master May 6, 2023
@thescientist13 thescientist13 deleted the bug/issue-1104-api-routes-not-fully-reloading-changes-in-dev-mode branch May 6, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP SSR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

imported modules in API routes not reloading changes in development mode
1 participant
@thescientist13