OOFF Contribution Status change batch fails

[kainuk]

After sending the xml file with OOFF transactions, successfully to the bank, the batch that updates the status from Pending to Complete fails. The batch stops in the screen below.

In the background an error is thrown.

TypeError: implode(): Argument #1 ($pieces) must be of type array, string given in implode() (line 187 of /var/www/html/web/sites/default/files/civicrm/ext/org.project60.sepa/CRM/Sepa/Logic/Queue/Close.php).

I have this error on the latest version of the sepa code with a PHP 8.1 install and CiviCRM 5.67 on Drupal 10.

[pminf]

I can confirm this issue with latest CiviCRM 5.74.1, also using PHP 8.1.

In our case \CRM_Sepa_Logic_Queue_Close::$origin_status_ids is null, which leads to an error with the implode function.

[bjendres]

Thanks for reporting @kainuk and @pminf! Will you be working on a PR, or "just" reporting?

[kainuk]

Hi @bjendres, I have made a PR, see #722 , but I would like feedback on it.

[Detsieber]

I had this same issue on a large install (CiviCRM 5.74.4, CiviSEPA 1.10.0(!)), and this fix (#722) is working for us.
Thank you @kainuk so much!

Please merge.

[peth-systopia]

As @kainuk also indicates, this ist not (yet) a quick merge. So still 'needs funding'.

[Detsieber]

I don't know under which conditions this error occurs - but it breaks CiviSEPA completely!

IMHO, releasing a fix is important.

[peth-systopia]

IMHO, releasing a fix is important.

Can we count on you for some funding then?

[pminf]

We've tested https://github.com/Project60/org.project60.sepa/releases/tag/1.11-alpha1 including this fix successfully.