Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: 검색 결과 데이터 반환 개수 수정 #300

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

gitseoyeon
Copy link
Member

Summary

Key Changes

  • boothService 안 createBoothPageRequest 메소드에서 반환한 pageSize를 8로 수정
  • eventService 안 createEventPageRequest 메소드에서 반환한 pageSize를 8로 수정

Testing

  • 결과 값
image image

To Reviewers

  • 원래는 size라는 파라미터를 따로 입력 받아서 입력하는대로 size를 조정할 수 있게 하려다가 어짜피 프론트 화면에서 보여질 값은 8로 고정될 듯해서 8로 고정 값을 주었습니다.
  • 질문이나 의견 있으시면 코멘트 남겨주세요!

@gitseoyeon gitseoyeon added the refactor 코드를 개선합니다. label Nov 8, 2024
@gitseoyeon gitseoyeon requested a review from muncool39 November 8, 2024 06:56
@gitseoyeon gitseoyeon self-assigned this Nov 8, 2024
Copy link
Member

@muncool39 muncool39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 확인했습니다! 수고하셨습니다! 😄

@gitseoyeon gitseoyeon merged commit 69d3e82 into dev Nov 8, 2024
3 checks passed
@gitseoyeon gitseoyeon deleted the refactor/#299 branch November 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드를 개선합니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 검색 결과 페이징 관련 수정
2 participants