Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: 공지 등록시 이미지 null 일 때 처리 #270

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix: 공지 등록시 이미지 null 일 때 처리 #270

merged 3 commits into from
Oct 11, 2024

Conversation

gitseoyeon
Copy link
Member

Summary

Key Changes

  • 공지 객체 생성시 imageUrl 값에 null 일경우의 삼항 연산자 대입
  • 부스 리뷰 생성시 image 변수를 만들어서 null 값 처리 후 객체 생성을 했던 과정을 지우고 바로 객체 생성시에 null 값 처리를 동시에 하도록 했습니다.

Testing

ex) 부스 공지 등록
POST /booths/boothId/notices
image
image

To Reviewers

의견이나 질문 있으시면 리뷰 남겨주세요!

@gitseoyeon gitseoyeon added the fix label Oct 11, 2024
@gitseoyeon gitseoyeon requested a review from muncool39 October 11, 2024 05:43
@gitseoyeon gitseoyeon self-assigned this Oct 11, 2024
muncool39
muncool39 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@muncool39 muncool39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 빠른 수정 감사합니다! 😭

@gitseoyeon gitseoyeon merged commit 0f23c0f into dev Oct 11, 2024
2 checks passed
@gitseoyeon gitseoyeon deleted the fix/#269 branch October 11, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muncool39 muncool39 muncool39 approved these changes

Assignees

@gitseoyeon gitseoyeon

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 공지 등록시 NullPointerException 문제
2 participants
@gitseoyeon @muncool39