-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Russian grammar tests #192
Conversation
148323a
to
0cdb844
Compare
0cdb844
to
ea581d8
Compare
Actually adding tests is infinite work but maybe somebody could review & merge this PR with made changes? All further efforts could be added with newer PRs (I have some plans to check all Russian street names collated by Russian street names validator but in some far away future)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience and for your diligence with these grammar rules. I agree that we can treat this as an ongoing effort and making further improvements in future PRs.
should I update change log with these quite minor fixes (especially for other languages) or not?
Sure, if you don’t mind.
languages/grammar/ru.json
Outdated
@@ -4,6 +4,8 @@ | |||
}, | |||
"v5": { | |||
"accusative": [ | |||
["^ [«\"](.+?)[»\"] ", " трасса \"$1\" "], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The speech synthesizers I tried seem to treat guillemets equivalently to quotation marks, so this rule would be fine. On the other hand, if the instruction is presented visually (which this library doesn’t rule out), is it expected that главная аллея «Годы войны» would be presented as главная аллея "Годы войны" instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking this - IMHO if modern TTSes could handle different quote styles internally (Garmin's old Nuance Vocalizer Automotive doesn't understand guillemets), it's better just to keep original quotes as is.
I added this change and updated the log.
552e05d
to
7fe63a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
@yuryleb, would you mind opening separate issues describing what you’re thinking of doing in this space? We might be able to get others to help with test cases as well. Thanks! |
This PR adds test names for all status street names in Russian grammar rules and fixes some detected errors in grammar expressions.