Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flatbuffers to v24.3.25 version #6968

Merged
merged 20 commits into from
Jul 10, 2024
Merged

Bump flatbuffers to v24.3.25 version #6968

merged 20 commits into from
Jul 10, 2024

Conversation

SiarheiFedartsou
Copy link
Member

@SiarheiFedartsou SiarheiFedartsou commented Jun 22, 2024

  • Update flatbuffers to the latest version
  • Use ./scripts/update_dependencies.sh for it
  • Move flatbuffers generated files out of include directory: this way we do not check it with clang-tidy
  • Small breaking change: I had to rename table Table in flatbuffers spec to table TableResult, otherwise flatbuffers compiler generated typedef Table Table; what some of GCC versions didn't like...

Benchmark Results

Benchmark Base PR
alias aliased u32: 1149.12
plain u32: 1147.83
aliased double: 1189.03
plain double: 1185.15
aliased u32: 1149.46
plain u32: 1153.89
aliased double: 1182.3
plain double: 1216.85
e2e_match_ch Ops: 43.25 ± 0.10 ops/s. Best: 43.48 ops/s
Total: 3028.93ms ± 7.64ms. Best: 3013.01ms
Min time: 2.21ms ± 0.04ms
Mean time: 23.12ms ± 0.06ms
Median time: 16.25ms ± 0.07ms
95th percentile: 75.74ms ± 0.32ms
99th percentile: 92.34ms ± 0.51ms
Max time: 105.73ms ± 0.70ms
Ops: 41.57 ± 0.11 ops/s. Best: 41.71 ops/s
Total: 3151.28ms ± 8.22ms. Best: 3140.78ms
Min time: 2.12ms ± 0.04ms
Mean time: 24.05ms ± 0.06ms
Median time: 17.61ms ± 0.20ms
95th percentile: 84.24ms ± 0.18ms
99th percentile: 103.22ms ± 0.92ms
Max time: 111.53ms ± 0.70ms
e2e_match_mld Ops: 64.83 ± 0.35 ops/s. Best: 65.22 ops/s
Total: 2020.92ms ± 10.77ms. Best: 2008.72ms
Min time: 1.75ms ± 0.02ms
Mean time: 15.43ms ± 0.08ms
Median time: 8.24ms ± 0.13ms
95th percentile: 51.31ms ± 0.17ms
99th percentile: 59.82ms ± 0.29ms
Max time: 69.11ms ± 0.34ms
Ops: 65.11 ± 0.16 ops/s. Best: 65.29 ops/s
Total: 2012.29ms ± 4.78ms. Best: 2006.40ms
Min time: 1.72ms ± 0.02ms
Mean time: 15.36ms ± 0.04ms
Median time: 8.09ms ± 0.12ms
95th percentile: 51.10ms ± 0.12ms
99th percentile: 59.88ms ± 0.19ms
Max time: 69.59ms ± 0.26ms
e2e_nearest_ch Ops: 863.94 ± 3.38 ops/s. Best: 869.39 ops/s
Total: 1157.50ms ± 4.75ms. Best: 1150.23ms
Min time: 0.99ms ± 0.00ms
Mean time: 1.16ms ± 0.00ms
Median time: 1.07ms ± 0.00ms
95th percentile: 1.61ms ± 0.01ms
99th percentile: 1.66ms ± 0.01ms
Max time: 5.87ms ± 2.72ms
Ops: 868.07 ± 3.69 ops/s. Best: 872.61 ops/s
Total: 1152.07ms ± 5.09ms. Best: 1145.98ms
Min time: 0.99ms ± 0.00ms
Mean time: 1.15ms ± 0.01ms
Median time: 1.06ms ± 0.00ms
95th percentile: 1.60ms ± 0.00ms
99th percentile: 1.65ms ± 0.01ms
Max time: 6.47ms ± 3.08ms
e2e_nearest_mld Ops: 866.06 ± 3.21 ops/s. Best: 871.40 ops/s
Total: 1154.70ms ± 4.50ms. Best: 1147.58ms
Min time: 0.99ms ± 0.00ms
Mean time: 1.15ms ± 0.00ms
Median time: 1.07ms ± 0.00ms
95th percentile: 1.60ms ± 0.00ms
99th percentile: 1.65ms ± 0.01ms
Max time: 5.75ms ± 2.69ms
Ops: 861.31 ± 3.11 ops/s. Best: 866.12 ops/s
Total: 1161.01ms ± 4.29ms. Best: 1154.58ms
Min time: 0.99ms ± 0.00ms
Mean time: 1.16ms ± 0.00ms
Median time: 1.07ms ± 0.00ms
95th percentile: 1.60ms ± 0.00ms
99th percentile: 1.65ms ± 0.01ms
Max time: 6.37ms ± 3.12ms
e2e_route_ch Ops: 365.52 ± 2.96 ops/s. Best: 371.47 ops/s
Total: 2736.08ms ± 22.18ms. Best: 2691.97ms
Min time: 1.20ms ± 0.00ms
Mean time: 2.74ms ± 0.02ms
Median time: 2.75ms ± 0.02ms
95th percentile: 3.62ms ± 0.03ms
99th percentile: 4.04ms ± 0.04ms
Max time: 6.56ms ± 2.20ms
Ops: 370.57 ± 0.96 ops/s. Best: 371.69 ops/s
Total: 2698.73ms ± 6.93ms. Best: 2690.43ms
Min time: 1.21ms ± 0.00ms
Mean time: 2.70ms ± 0.01ms
Median time: 2.72ms ± 0.01ms
95th percentile: 3.56ms ± 0.01ms
99th percentile: 3.95ms ± 0.03ms
Max time: 6.61ms ± 2.28ms
e2e_route_mld Ops: 306.15 ± 0.42 ops/s. Best: 307.13 ops/s
Total: 3266.46ms ± 4.74ms. Best: 3255.95ms
Min time: 1.21ms ± 0.01ms
Mean time: 3.27ms ± 0.00ms
Median time: 3.31ms ± 0.01ms
95th percentile: 4.45ms ± 0.01ms
99th percentile: 4.95ms ± 0.06ms
Max time: 7.46ms ± 2.01ms
Ops: 308.57 ± 0.37 ops/s. Best: 309.33 ops/s
Total: 3240.77ms ± 4.19ms. Best: 3232.76ms
Min time: 1.21ms ± 0.01ms
Mean time: 3.24ms ± 0.00ms
Median time: 3.27ms ± 0.00ms
95th percentile: 4.43ms ± 0.02ms
99th percentile: 4.91ms ± 0.06ms
Max time: 7.87ms ± 2.41ms
e2e_table_ch Ops: 325.28 ± 0.71 ops/s. Best: 326.23 ops/s
Total: 3073.98ms ± 6.70ms. Best: 3065.32ms
Min time: 1.63ms ± 0.03ms
Mean time: 3.07ms ± 0.01ms
Median time: 3.07ms ± 0.01ms
95th percentile: 4.26ms ± 0.02ms
99th percentile: 4.58ms ± 0.06ms
Max time: 8.21ms ± 2.36ms
Ops: 311.11 ± 0.56 ops/s. Best: 312.21 ops/s
Total: 3214.22ms ± 6.35ms. Best: 3202.99ms
Min time: 1.64ms ± 0.02ms
Mean time: 3.21ms ± 0.01ms
Median time: 3.21ms ± 0.01ms
95th percentile: 4.50ms ± 0.01ms
99th percentile: 4.80ms ± 0.06ms
Max time: 8.32ms ± 2.27ms
e2e_table_mld Ops: 110.08 ± 0.13 ops/s. Best: 110.33 ops/s
Total: 9083.90ms ± 10.99ms. Best: 9063.67ms
Min time: 3.66ms ± 0.05ms
Mean time: 9.08ms ± 0.01ms
Median time: 9.06ms ± 0.03ms
95th percentile: 13.90ms ± 0.04ms
99th percentile: 14.55ms ± 0.09ms
Max time: 17.65ms ± 2.35ms
Ops: 110.95 ± 0.13 ops/s. Best: 111.14 ops/s
Total: 9012.69ms ± 10.23ms. Best: 8997.80ms
Min time: 3.67ms ± 0.03ms
Mean time: 9.01ms ± 0.01ms
Median time: 8.98ms ± 0.04ms
95th percentile: 13.82ms ± 0.05ms
99th percentile: 14.45ms ± 0.05ms
Max time: 17.22ms ± 2.34ms
e2e_trip_ch Ops: 99.39 ± 1.29 ops/s. Best: 101.22 ops/s
Total: 10067.95ms ± 139.80ms. Best: 9879.06ms
Min time: 1.49ms ± 0.09ms
Mean time: 10.06ms ± 0.14ms
Median time: 9.52ms ± 0.16ms
95th percentile: 18.11ms ± 0.18ms
99th percentile: 20.03ms ± 0.23ms
Max time: 21.79ms ± 0.42ms
Ops: 99.98 ± 0.16 ops/s. Best: 100.17 ops/s
Total: 10002.94ms ± 15.87ms. Best: 9982.83ms
Min time: 1.42ms ± 0.06ms
Mean time: 10.00ms ± 0.02ms
Median time: 9.42ms ± 0.04ms
95th percentile: 18.15ms ± 0.03ms
99th percentile: 20.07ms ± 0.22ms
Max time: 22.64ms ± 1.36ms
e2e_trip_mld Ops: 58.84 ± 0.09 ops/s. Best: 59.04 ops/s
Total: 16994.41ms ± 28.06ms. Best: 16938.18ms
Min time: 1.60ms ± 0.25ms
Mean time: 16.99ms ± 0.03ms
Median time: 16.49ms ± 0.03ms
95th percentile: 27.90ms ± 0.09ms
99th percentile: 30.08ms ± 0.12ms
Max time: 32.08ms ± 0.54ms
Ops: 59.33 ± 0.07 ops/s. Best: 59.41 ops/s
Total: 16855.19ms ± 20.97ms. Best: 16831.84ms
Min time: 1.66ms ± 0.23ms
Mean time: 16.86ms ± 0.02ms
Median time: 16.32ms ± 0.02ms
95th percentile: 28.10ms ± 0.09ms
99th percentile: 30.35ms ± 0.16ms
Max time: 32.11ms ± 0.58ms
json-render String: 5.55584ms
Stringstream: 8.9209ms
Vector: 6.60303ms
String: 5.58656ms
Stringstream: 9.08362ms
Vector: 6.62261ms
match_ch Default radius:
4.6097ms/req at 82 coordinate
0.0562159ms/coordinate
Radius 10m:
16.1451ms/req at 82 coordinate
0.196891ms/coordinate
Default radius:
4.63933ms/req at 82 coordinate
0.0565772ms/coordinate
Radius 10m:
16.0977ms/req at 82 coordinate
0.196314ms/coordinate
match_mld Default radius:
3.01923ms/req at 82 coordinate
0.0368199ms/coordinate
Radius 10m:
11.2664ms/req at 82 coordinate
0.137395ms/coordinate
Default radius:
3.11766ms/req at 82 coordinate
0.0380202ms/coordinate
Radius 10m:
11.2917ms/req at 82 coordinate
0.137704ms/coordinate
osrm_contract Time: 98.27s Peak RAM: 200.55MB Time: 100.85s Peak RAM: 200.98MB
osrm_customize Time: 1.30s Peak RAM: 117.49MB Time: 1.30s Peak RAM: 117.81MB
osrm_extract Time: 11.70s Peak RAM: 430.78MB Time: 11.60s Peak RAM: 430.34MB
osrm_partition Time: 2.09s Peak RAM: 152.14MB Time: 2.10s Peak RAM: 142.87MB
packedvector random write:
std::vector 11331.3 ms
util::packed_vector 73533 ms
slowdown: 6.48938
random read:
std::vector 11125.2 ms
util::packed_vector 30474 ms
slowdown: 2.73919
random write:
std::vector 11355.4 ms
util::packed_vector 73783.5 ms
slowdown: 6.49766
random read:
std::vector 11121.2 ms
util::packed_vector 30596.4 ms
slowdown: 2.75118
random_match_ch 500 matches, default radius
ops: 198.88 ± 1.07 ops/s. best: 199.77ops/s.
total: 286.62 ± 1.56ms. best: 285.33ms.
avg: 5.03 ± 0.03ms
min: 0.13 ± 0.01ms
max: 27.04 ± 0.07ms
p99: 27.04 ± 0.07ms

500 matches, radius=10
ops: 58.37 ± 0.09 ops/s. best: 58.48ops/s.
total: 1096.51 ± 1.64ms. best: 1094.42ms.
avg: 17.13 ± 0.03ms
min: 0.15 ± 0.00ms
max: 258.61 ± 0.47ms
p99: 258.61 ± 0.47ms

500 matches, radius=20
ops: 14.07 ± 0.02 ops/s. best: 14.09ops/s.
total: 4618.30 ± 4.99ms. best: 4613.13ms.
avg: 71.05 ± 0.08ms
min: 0.31 ± 0.00ms
max: 1280.26 ± 4.24ms
p99: 1280.26 ± 4.24ms
500 matches, default radius
ops: 196.02 ± 0.53 ops/s. best: 196.78ops/s.
total: 290.80 ± 0.78ms. best: 289.66ms.
avg: 5.10 ± 0.01ms
min: 0.13 ± 0.01ms
max: 28.66 ± 0.11ms
p99: 28.66 ± 0.11ms

500 matches, radius=10
ops: 58.16 ± 0.21 ops/s. best: 58.44ops/s.
total: 1100.52 ± 4.05ms. best: 1095.15ms.
avg: 17.20 ± 0.06ms
min: 0.15 ± 0.00ms
max: 246.90 ± 1.79ms
p99: 246.90 ± 1.79ms

500 matches, radius=20
ops: 13.99 ± 0.05 ops/s. best: 14.07ops/s.
total: 4645.28 ± 16.68ms. best: 4619.41ms.
avg: 71.47 ± 0.26ms
min: 0.30 ± 0.00ms
max: 1227.53 ± 4.74ms
p99: 1227.53 ± 4.74ms
random_match_mld 500 matches, default radius
ops: 307.73 ± 2.18 ops/s. best: 309.51ops/s.
total: 185.24 ± 1.33ms. best: 184.16ms.
avg: 3.25 ± 0.02ms
min: 0.11 ± 0.01ms
max: 18.81 ± 0.03ms
p99: 18.81 ± 0.03ms

500 matches, radius=10
ops: 108.21 ± 0.82 ops/s. best: 108.93ops/s.
total: 591.48 ± 4.51ms. best: 587.56ms.
avg: 9.24 ± 0.07ms
min: 0.14 ± 0.00ms
max: 110.55 ± 1.04ms
p99: 110.55 ± 1.04ms

500 matches, radius=20
ops: 21.97 ± 0.17 ops/s. best: 22.13ops/s.
total: 2958.71 ± 22.64ms. best: 2937.11ms.
avg: 45.52 ± 0.35ms
min: 0.20 ± 0.00ms
max: 577.67 ± 4.70ms
p99: 577.67 ± 4.70ms
500 matches, default radius
ops: 307.70 ± 2.14 ops/s. best: 309.40ops/s.
total: 185.26 ± 1.30ms. best: 184.23ms.
avg: 3.25 ± 0.02ms
min: 0.12 ± 0.01ms
max: 18.84 ± 0.05ms
p99: 18.84 ± 0.05ms

500 matches, radius=10
ops: 108.42 ± 0.17 ops/s. best: 108.67ops/s.
total: 590.28 ± 0.93ms. best: 588.95ms.
avg: 9.22 ± 0.01ms
min: 0.14 ± 0.00ms
max: 110.77 ± 0.43ms
p99: 110.77 ± 0.43ms

500 matches, radius=20
ops: 21.98 ± 0.03 ops/s. best: 22.03ops/s.
total: 2957.75 ± 3.84ms. best: 2950.32ms.
avg: 45.50 ± 0.06ms
min: 0.19 ± 0.00ms
max: 579.94 ± 1.39ms
p99: 579.94 ± 1.39ms
random_nearest_ch 10000 nearest, number_of_results=1
ops: 24726.74 ± 76.05 ops/s. best: 24785.66ops/s.
total: 404.43 ± 1.25ms. best: 403.46ms.
avg: 0.04 ± 0.00ms
min: 0.01 ± 0.00ms
max: 0.17 ± 0.05ms
p99: 0.10 ± 0.00ms

10000 nearest, number_of_results=5
ops: 19077.42 ± 18.01 ops/s. best: 19099.32ops/s.
total: 524.18 ± 0.50ms. best: 523.58ms.
avg: 0.05 ± 0.00ms
min: 0.02 ± 0.00ms
max: 0.15 ± 0.00ms
p99: 0.11 ± 0.00ms

10000 nearest, number_of_results=10
ops: 15045.66 ± 33.59 ops/s. best: 15085.81ops/s.
total: 664.65 ± 1.48ms. best: 662.87ms.
avg: 0.07 ± 0.00ms
min: 0.03 ± 0.00ms
max: 0.20 ± 0.03ms
p99: 0.13 ± 0.00ms
10000 nearest, number_of_results=1
ops: 25042.20 ± 103.34 ops/s. best: 25128.16ops/s.
total: 399.34 ± 1.66ms. best: 397.96ms.
avg: 0.04 ± 0.00ms
min: 0.01 ± 0.00ms
max: 0.17 ± 0.05ms
p99: 0.10 ± 0.00ms

10000 nearest, number_of_results=5
ops: 19184.10 ± 34.69 ops/s. best: 19223.82ops/s.
total: 521.27 ± 0.94ms. best: 520.19ms.
avg: 0.05 ± 0.00ms
min: 0.02 ± 0.00ms
max: 0.16 ± 0.01ms
p99: 0.11 ± 0.00ms

10000 nearest, number_of_results=10
ops: 15154.54 ± 13.05 ops/s. best: 15173.31ops/s.
total: 659.87 ± 0.57ms. best: 659.05ms.
avg: 0.07 ± 0.00ms
min: 0.03 ± 0.00ms
max: 0.18 ± 0.01ms
p99: 0.13 ± 0.00ms
random_nearest_mld 10000 nearest, number_of_results=1
ops: 24735.15 ± 70.81 ops/s. best: 24792.19ops/s.
total: 404.29 ± 1.16ms. best: 403.35ms.
avg: 0.04 ± 0.00ms
min: 0.01 ± 0.00ms
max: 0.17 ± 0.04ms
p99: 0.10 ± 0.00ms

10000 nearest, number_of_results=5
ops: 19019.47 ± 34.36 ops/s. best: 19051.43ops/s.
total: 525.78 ± 0.95ms. best: 524.89ms.
avg: 0.05 ± 0.00ms
min: 0.02 ± 0.00ms
max: 0.15 ± 0.00ms
p99: 0.11 ± 0.00ms

10000 nearest, number_of_results=10
ops: 15067.63 ± 14.10 ops/s. best: 15085.30ops/s.
total: 663.68 ± 0.62ms. best: 662.90ms.
avg: 0.07 ± 0.00ms
min: 0.03 ± 0.00ms
max: 0.18 ± 0.01ms
p99: 0.13 ± 0.00ms
10000 nearest, number_of_results=1
ops: 24845.43 ± 59.49 ops/s. best: 24902.03ops/s.
total: 402.49 ± 0.97ms. best: 401.57ms.
avg: 0.04 ± 0.00ms
min: 0.01 ± 0.00ms
max: 0.17 ± 0.05ms
p99: 0.10 ± 0.00ms

10000 nearest, number_of_results=5
ops: 19103.98 ± 13.75 ops/s. best: 19130.66ops/s.
total: 523.45 ± 0.38ms. best: 522.72ms.
avg: 0.05 ± 0.00ms
min: 0.02 ± 0.00ms
max: 0.15 ± 0.00ms
p99: 0.11 ± 0.00ms

10000 nearest, number_of_results=10
ops: 15073.00 ± 18.82 ops/s. best: 15095.45ops/s.
total: 663.44 ± 0.83ms. best: 662.45ms.
avg: 0.07 ± 0.00ms
min: 0.03 ± 0.00ms
max: 0.20 ± 0.03ms
p99: 0.13 ± 0.00ms
random_route_ch 1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
ops: 522.20 ± 2.25 ops/s. best: 525.05ops/s.
total: 1884.37 ± 8.27ms. best: 1874.09ms.
avg: 1.92 ± 0.01ms
min: 0.31 ± 0.00ms
max: 3.28 ± 0.29ms
p99: 2.77 ± 0.04ms

1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
ops: 587.68 ± 1.70 ops/s. best: 590.94ops/s.
total: 1701.62 ± 4.91ms. best: 1692.22ms.
avg: 1.70 ± 0.00ms
min: 0.06 ± 0.00ms
max: 4.67 ± 0.21ms
p99: 4.20 ± 0.02ms

1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
ops: 990.25 ± 5.91 ops/s. best: 997.87ops/s.
total: 993.73 ± 5.95ms. best: 986.10ms.
avg: 1.01 ± 0.01ms
min: 0.26 ± 0.00ms
max: 1.64 ± 0.08ms
p99: 1.43 ± 0.02ms

1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
ops: 1039.69 ± 3.10 ops/s. best: 1044.59ops/s.
total: 961.84 ± 2.87ms. best: 957.31ms.
avg: 0.96 ± 0.00ms
min: 0.04 ± 0.00ms
max: 3.11 ± 0.03ms
p99: 2.95 ± 0.01ms
1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
ops: 513.54 ± 1.26 ops/s. best: 515.25ops/s.
total: 1916.14 ± 4.72ms. best: 1909.74ms.
avg: 1.95 ± 0.00ms
min: 0.31 ± 0.01ms
max: 3.29 ± 0.35ms
p99: 2.76 ± 0.02ms

1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
ops: 579.54 ± 2.91 ops/s. best: 583.72ops/s.
total: 1725.57 ± 8.68ms. best: 1713.14ms.
avg: 1.73 ± 0.01ms
min: 0.06 ± 0.00ms
max: 4.39 ± 0.10ms
p99: 3.70 ± 0.06ms

1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
ops: 978.21 ± 2.70 ops/s. best: 981.19ops/s.
total: 1005.92 ± 2.78ms. best: 1002.86ms.
avg: 1.02 ± 0.00ms
min: 0.26 ± 0.00ms
max: 1.72 ± 0.02ms
p99: 1.47 ± 0.02ms

1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
ops: 1035.13 ± 3.00 ops/s. best: 1039.41ops/s.
total: 966.08 ± 2.80ms. best: 962.08ms.
avg: 0.97 ± 0.00ms
min: 0.04 ± 0.00ms
max: 3.18 ± 0.02ms
p99: 2.17 ± 0.03ms
random_route_mld 1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
ops: 248.05 ± 0.44 ops/s. best: 248.69ops/s.
total: 3966.95 ± 6.97ms. best: 3956.80ms.
avg: 4.03 ± 0.01ms
min: 0.31 ± 0.01ms
max: 8.78 ± 0.05ms
p99: 6.86 ± 0.06ms

1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
ops: 239.00 ± 0.49 ops/s. best: 239.44ops/s.
total: 4184.18 ± 8.60ms. best: 4176.43ms.
avg: 4.18 ± 0.01ms
min: 0.05 ± 0.00ms
max: 9.61 ± 0.28ms
p99: 8.50 ± 0.03ms

1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
ops: 320.82 ± 0.42 ops/s. best: 321.52ops/s.
total: 3067.18 ± 4.01ms. best: 3060.49ms.
avg: 3.12 ± 0.00ms
min: 0.28 ± 0.00ms
max: 7.42 ± 0.03ms
p99: 5.34 ± 0.05ms

1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
ops: 293.70 ± 0.76 ops/s. best: 294.95ops/s.
total: 3404.85 ± 8.91ms. best: 3390.35ms.
avg: 3.40 ± 0.01ms
min: 0.04 ± 0.00ms
max: 7.31 ± 0.14ms
p99: 6.70 ± 0.05ms
1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
ops: 251.08 ± 0.96 ops/s. best: 252.57ops/s.
total: 3919.15 ± 14.93ms. best: 3895.91ms.
avg: 3.98 ± 0.02ms
min: 0.30 ± 0.00ms
max: 8.67 ± 0.07ms
p99: 6.69 ± 0.06ms

1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
ops: 243.69 ± 0.46 ops/s. best: 244.60ops/s.
total: 4103.65 ± 7.76ms. best: 4088.25ms.
avg: 4.10 ± 0.01ms
min: 0.06 ± 0.00ms
max: 9.32 ± 0.26ms
p99: 8.37 ± 0.06ms

1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
ops: 330.07 ± 0.60 ops/s. best: 330.81ops/s.
total: 2981.17 ± 5.40ms. best: 2974.51ms.
avg: 3.03 ± 0.01ms
min: 0.28 ± 0.01ms
max: 7.27 ± 0.02ms
p99: 5.16 ± 0.05ms

1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
ops: 299.26 ± 0.64 ops/s. best: 300.22ops/s.
total: 3341.57 ± 7.17ms. best: 3330.92ms.
avg: 3.34 ± 0.01ms
min: 0.04 ± 0.00ms
max: 7.30 ± 0.19ms
p99: 6.63 ± 0.04ms
random_table_ch 250 tables, 3 coordinates
ops: 1479.40 ± 14.24 ops/s. best: 1493.16ops/s.
total: 169.01 ± 1.64ms. best: 167.43ms.
avg: 0.68 ± 0.01ms
min: 0.52 ± 0.00ms
max: 1.04 ± 0.27ms
p99: 0.84 ± 0.04ms

250 tables, 25 coordinates
ops: 173.39 ± 0.14 ops/s. best: 173.57ops/s.
total: 1441.84 ± 1.14ms. best: 1440.34ms.
avg: 5.77 ± 0.00ms
min: 5.20 ± 0.01ms
max: 6.51 ± 0.42ms
p99: 6.20 ± 0.03ms

250 tables, 50 coordinates
ops: 85.70 ± 0.09 ops/s. best: 85.84ops/s.
total: 2917.06 ± 3.02ms. best: 2912.35ms.
avg: 11.67 ± 0.01ms
min: 10.85 ± 0.02ms
max: 12.89 ± 0.26ms
p99: 12.56 ± 0.13ms
250 tables, 3 coordinates
ops: 1374.50 ± 10.20 ops/s. best: 1383.83ops/s.
total: 181.90 ± 1.36ms. best: 180.66ms.
avg: 0.73 ± 0.01ms
min: 0.52 ± 0.01ms
max: 1.12 ± 0.28ms
p99: 0.93 ± 0.02ms

250 tables, 25 coordinates
ops: 160.90 ± 0.09 ops/s. best: 161.07ops/s.
total: 1553.79 ± 0.84ms. best: 1552.11ms.
avg: 6.22 ± 0.00ms
min: 5.47 ± 0.01ms
max: 6.81 ± 0.01ms
p99: 6.77 ± 0.02ms

250 tables, 50 coordinates
ops: 78.99 ± 0.06 ops/s. best: 79.12ops/s.
total: 3164.81 ± 2.28ms. best: 3159.72ms.
avg: 12.66 ± 0.01ms
min: 11.70 ± 0.03ms
max: 13.79 ± 0.07ms
p99: 13.51 ± 0.04ms
random_table_mld 250 tables, 3 coordinates
ops: 333.26 ± 0.65 ops/s. best: 333.97ops/s.
total: 750.18 ± 1.47ms. best: 748.56ms.
avg: 3.00 ± 0.01ms
min: 2.52 ± 0.01ms
max: 3.93 ± 0.20ms
p99: 3.58 ± 0.08ms

250 tables, 25 coordinates
ops: 37.05 ± 0.02 ops/s. best: 37.08ops/s.
total: 6747.32 ± 3.64ms. best: 6742.34ms.
avg: 26.99 ± 0.01ms
min: 25.39 ± 0.07ms
max: 28.97 ± 0.20ms
p99: 28.65 ± 0.11ms

250 tables, 50 coordinates
ops: 17.50 ± 0.01 ops/s. best: 17.52ops/s.
total: 14284.31 ± 11.38ms. best: 14267.09ms.
avg: 57.14 ± 0.05ms
min: 55.04 ± 0.09ms
max: 60.39 ± 0.72ms
p99: 59.44 ± 0.10ms
250 tables, 3 coordinates
ops: 335.88 ± 0.84 ops/s. best: 336.83ops/s.
total: 744.32 ± 1.93ms. best: 742.21ms.
avg: 2.98 ± 0.01ms
min: 2.50 ± 0.01ms
max: 3.89 ± 0.24ms
p99: 3.55 ± 0.05ms

250 tables, 25 coordinates
ops: 37.22 ± 0.04 ops/s. best: 37.26ops/s.
total: 6717.29 ± 7.43ms. best: 6710.31ms.
avg: 26.87 ± 0.03ms
min: 25.26 ± 0.07ms
max: 29.50 ± 0.73ms
p99: 28.91 ± 0.53ms

250 tables, 50 coordinates
ops: 17.59 ± 0.01 ops/s. best: 17.61ops/s.
total: 14210.38 ± 6.25ms. best: 14198.26ms.
avg: 56.84 ± 0.03ms
min: 54.70 ± 0.04ms
max: 59.90 ± 0.35ms
p99: 59.44 ± 0.14ms
random_trip_ch 250 trips, 3 coordinates
ops: 496.31 ± 2.84 ops/s. best: 500.82ops/s.
total: 503.74 ± 2.87ms. best: 499.18ms.
avg: 2.01 ± 0.01ms
min: 1.07 ± 0.01ms
max: 2.99 ± 0.31ms
p99: 2.63 ± 0.05ms

250 trips, 5 coordinates
ops: 328.98 ± 0.58 ops/s. best: 329.82ops/s.
total: 759.92 ± 1.34ms. best: 757.98ms.
avg: 3.04 ± 0.01ms
min: 1.93 ± 0.02ms
max: 3.78 ± 0.12ms
p99: 3.67 ± 0.04ms
250 trips, 3 coordinates
ops: 483.83 ± 7.29 ops/s. best: 489.85ops/s.
total: 516.87 ± 7.94ms. best: 510.36ms.
avg: 2.07 ± 0.03ms
min: 1.27 ± 0.01ms
max: 3.24 ± 0.40ms
p99: 2.84 ± 0.29ms

250 trips, 5 coordinates
ops: 323.42 ± 1.16 ops/s. best: 325.48ops/s.
total: 772.99 ± 2.76ms. best: 768.10ms.
avg: 3.09 ± 0.01ms
min: 2.10 ± 0.04ms
max: 3.87 ± 0.06ms
p99: 3.77 ± 0.03ms
random_trip_mld 250 trips, 3 coordinates
ops: 169.00 ± 0.45 ops/s. best: 169.93ops/s.
total: 1479.29 ± 3.88ms. best: 1471.23ms.
avg: 5.92 ± 0.02ms
min: 3.56 ± 0.06ms
max: 8.10 ± 0.46ms
p99: 7.63 ± 0.11ms

250 trips, 5 coordinates
ops: 110.53 ± 0.26 ops/s. best: 111.01ops/s.
total: 2261.78 ± 5.35ms. best: 2252.10ms.
avg: 9.05 ± 0.02ms
min: 6.58 ± 0.01ms
max: 11.12 ± 0.40ms
p99: 10.78 ± 0.15ms
250 trips, 3 coordinates
ops: 170.75 ± 0.98 ops/s. best: 171.83ops/s.
total: 1464.19 ± 8.47ms. best: 1454.96ms.
avg: 5.86 ± 0.03ms
min: 3.56 ± 0.05ms
max: 7.95 ± 0.49ms
p99: 7.44 ± 0.09ms

250 trips, 5 coordinates
ops: 111.09 ± 0.28 ops/s. best: 111.59ops/s.
total: 2250.44 ± 5.58ms. best: 2240.41ms.
avg: 9.00 ± 0.02ms
min: 6.54 ± 0.01ms
max: 11.21 ± 0.53ms
p99: 10.69 ± 0.06ms
route_ch 1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
428.475ms
0.428475ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
510.573ms
0.510573ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
155.473ms
0.155473ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
136.521ms
0.136521ms/req
1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
423.519ms
0.423519ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
506.757ms
0.506757ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
148.056ms
0.148056ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
130.397ms
0.130397ms/req
route_mld 1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
564.294ms
0.564294ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
709.845ms
0.709845ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
293.196ms
0.293196ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
323.701ms
0.323701ms/req
1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
574.121ms
0.574121ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
722.001ms
0.722001ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
289.714ms
0.289714ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
314.551ms
0.314551ms/req
rtree 1 result:
197.296ms -> 0.0197296 ms/query
10 results:
232.931ms -> 0.0232931 ms/query
1 result:
197.299ms -> 0.0197299 ms/query
10 results:
232.918ms -> 0.0232918 ms/query

@SiarheiFedartsou SiarheiFedartsou marked this pull request as ready for review June 22, 2024 17:26
Copy link
Collaborator

@DennisOSRM DennisOSRM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does the 200k LOCs net increase come from? Did we only pull in parts of flatbuffers before?

@SiarheiFedartsou
Copy link
Member Author

@DennisOSRM good question, I think I can remove some parts of flatbuffers which are not really needed 🤔 I mean tests, examples, docs etc. Likely we didn’t have it before.

@SiarheiFedartsou
Copy link
Member Author

@DennisOSRM now we delete 2x more lines than add 😄
Screenshot 2024-07-09 at 21 38 14

@SiarheiFedartsou SiarheiFedartsou merged commit 825132e into master Jul 10, 2024
21 checks passed
@SiarheiFedartsou SiarheiFedartsou deleted the sf-flatbuffers branch July 10, 2024 18:44
@DennisOSRM
Copy link
Collaborator

In hindsight the move of the .fbs files under a directory called 'generated' seems wrong. The definitions are not generated, but only the C++ code derived from it.

@SiarheiFedartsou
Copy link
Member Author

In hindsight the move of the .fbs files under a directory called 'generated' seems wrong. The definitions are not generated, but only the C++ code derived from it.

Indeed. @DennisOSRM do you think I should move them back? Or to some another folder?

@DennisOSRM
Copy link
Collaborator

Moving them back is perhaps the easiest fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants