Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance-noexcept-move-constructor clang-tidy warning #6933

Merged
merged 10 commits into from
Jun 8, 2024

Conversation

SiarheiFedartsou
Copy link
Member

@SiarheiFedartsou SiarheiFedartsou commented Jun 7, 2024

Benchmark Results

Benchmark Base PR
alias aliased u32: 1102.58
plain u32: 1094.19
aliased double: 953.45
plain double: 950.449
aliased u32: 1090
plain u32: 1092.31
aliased double: 959.847
plain double: 952.227
e2e_match_ch requests: 344
failures: 0
req/s: 5.734req/s
avg: 5.349ms
50%: 3ms
75%: 4ms
95%: 15ms
98%: 48ms
99%: 80ms
min: 1.274ms
max: 95.968ms
requests: 361
failures: 0
req/s: 6.021req/s
avg: 4.955ms
50%: 3ms
75%: 4ms
95%: 15ms
98%: 26ms
99%: 52ms
min: 1.249ms
max: 101.692ms
e2e_match_mld requests: 359
failures: 0
req/s: 5.995req/s
avg: 4.669ms
50%: 3ms
75%: 4ms
95%: 13ms
98%: 19ms
99%: 37ms
min: 1.495ms
max: 53.106ms
requests: 371
failures: 0
req/s: 6.186req/s
avg: 4.972ms
50%: 3ms
75%: 4ms
95%: 17ms
98%: 33ms
99%: 46ms
min: 1.258ms
max: 66.049ms
e2e_nearest_ch requests: 422
failures: 0
req/s: 7.034req/s
avg: 1.553ms
50%: 2ms
75%: 2ms
95%: 2ms
98%: 2ms
99%: 2ms
min: 1.007ms
max: 3.340ms
requests: 444
failures: 0
req/s: 7.405req/s
avg: 1.521ms
50%: 1ms
75%: 2ms
95%: 2ms
98%: 2ms
99%: 2ms
min: 1.072ms
max: 4.366ms
e2e_nearest_mld requests: 422
failures: 0
req/s: 7.047req/s
avg: 1.696ms
50%: 2ms
75%: 2ms
95%: 2ms
98%: 3ms
99%: 3ms
min: 1.140ms
max: 4.738ms
requests: 422
failures: 0
req/s: 7.037req/s
avg: 1.523ms
50%: 1ms
75%: 2ms
95%: 2ms
98%: 2ms
99%: 2ms
min: 1.076ms
max: 3.124ms
e2e_route_ch requests: 396
failures: 0
req/s: 6.601req/s
avg: 4.409ms
50%: 4ms
75%: 5ms
95%: 6ms
98%: 7ms
99%: 10ms
min: 1.242ms
max: 135.372ms
requests: 389
failures: 0
req/s: 6.488req/s
avg: 4.061ms
50%: 4ms
75%: 5ms
95%: 6ms
98%: 7ms
99%: 9ms
min: 1.495ms
max: 10.259ms
e2e_route_mld requests: 382
failures: 0
req/s: 6.379req/s
avg: 5.592ms
50%: 5ms
75%: 5ms
95%: 7ms
98%: 10ms
99%: 38ms
min: 1.738ms
max: 133.708ms
requests: 404
failures: 0
req/s: 6.737req/s
avg: 4.228ms
50%: 4ms
75%: 5ms
95%: 6ms
98%: 7ms
99%: 8ms
min: 1.391ms
max: 10.586ms
e2e_table_ch requests: 380
failures: 0
req/s: 6.334req/s
avg: 45.760ms
50%: 28ms
75%: 76ms
95%: 130ms
98%: 140ms
99%: 140ms
min: 2.381ms
max: 176.579ms
requests: 383
failures: 0
req/s: 6.388req/s
avg: 40.429ms
50%: 27ms
75%: 55ms
95%: 120ms
98%: 130ms
99%: 130ms
min: 3.061ms
max: 165.447ms
e2e_table_mld requests: 378
failures: 0
req/s: 6.312req/s
avg: 71.565ms
50%: 73ms
75%: 100ms
95%: 130ms
98%: 140ms
99%: 150ms
min: 4.543ms
max: 168.404ms
requests: 380
failures: 0
req/s: 6.337req/s
avg: 53.289ms
50%: 38ms
75%: 83ms
95%: 130ms
98%: 130ms
99%: 140ms
min: 2.473ms
max: 154.113ms
e2e_trip_ch requests: 370
failures: 0
req/s: 6.167req/s
avg: 16.001ms
50%: 15ms
75%: 21ms
95%: 30ms
98%: 33ms
99%: 34ms
min: 4.064ms
max: 36.300ms
requests: 356
failures: 0
req/s: 5.938req/s
avg: 16.339ms
50%: 15ms
75%: 20ms
95%: 31ms
98%: 33ms
99%: 35ms
min: 4.065ms
max: 44.516ms
e2e_trip_mld requests: 359
failures: 0
req/s: 5.995req/s
avg: 22.065ms
50%: 21ms
75%: 28ms
95%: 35ms
98%: 39ms
99%: 42ms
min: 5.952ms
max: 84.670ms
requests: 345
failures: 0
req/s: 5.753req/s
avg: 18.188ms
50%: 17ms
75%: 23ms
95%: 32ms
98%: 37ms
99%: 39ms
min: 3.983ms
max: 40.179ms
json-render String: 6.55045ms
Stringstream: 9.28397ms
Vector: 6.99187ms
String: 6.61233ms
Stringstream: 9.37551ms
Vector: 6.94386ms
match_ch Default radius:
4.40195ms/req at 82 coordinate
0.0536823ms/coordinate
Radius 5m:
4.37023ms/req at 82 coordinate
0.0532955ms/coordinate
Radius 10m:
14.9272ms/req at 82 coordinate
0.182039ms/coordinate
Radius 15m:
36.5714ms/req at 82 coordinate
0.445992ms/coordinate
Radius 30m:
311.882ms/req at 82 coordinate
3.80344ms/coordinate
Default radius:
4.41436ms/req at 82 coordinate
0.0538336ms/coordinate
Radius 5m:
4.39198ms/req at 82 coordinate
0.0535607ms/coordinate
Radius 10m:
15.035ms/req at 82 coordinate
0.183353ms/coordinate
Radius 15m:
36.5207ms/req at 82 coordinate
0.445375ms/coordinate
Radius 30m:
311.698ms/req at 82 coordinate
3.8012ms/coordinate
match_mld Default radius:
2.78667ms/req at 82 coordinate
0.0339838ms/coordinate
Radius 5m:
2.84428ms/req at 82 coordinate
0.0346864ms/coordinate
Radius 10m:
10.3432ms/req at 82 coordinate
0.126136ms/coordinate
Radius 15m:
25.7298ms/req at 82 coordinate
0.313777ms/coordinate
Radius 30m:
302.289ms/req at 82 coordinate
3.68645ms/coordinate
Default radius:
2.75586ms/req at 82 coordinate
0.033608ms/coordinate
Radius 5m:
2.74494ms/req at 82 coordinate
0.0334748ms/coordinate
Radius 10m:
10.1037ms/req at 82 coordinate
0.123216ms/coordinate
Radius 15m:
25.7695ms/req at 82 coordinate
0.314263ms/coordinate
Radius 30m:
300.826ms/req at 82 coordinate
3.6686ms/coordinate
osrm_contract Time: 94.21s Peak RAM: 185.54MB Time: 93.07s Peak RAM: 185.49MB
osrm_customize Time: 1.31s Peak RAM: 115.11MB Time: 1.31s Peak RAM: 115.10MB
osrm_extract Time: 12.10s Peak RAM: 404.58MB Time: 12.10s Peak RAM: 395.95MB
osrm_partition Time: 2.21s Peak RAM: 148.46MB Time: 2.18s Peak RAM: 148.46MB
packedvector random write:
std::vector 11107.2 ms
util::packed_vector 74876.7 ms
slowdown: 6.7413
random read:
std::vector 11129 ms
util::packed_vector 30968.8 ms
slowdown: 2.78272
random write:
std::vector 9751.37 ms
util::packed_vector 73639.6 ms
slowdown: 7.55172
random read:
std::vector 8424.02 ms
util::packed_vector 30253.6 ms
slowdown: 3.59135
route_ch 1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
512.899ms
0.512899ms/req
1000 routes, 2 coordinates, no alternatives, overview=full, steps=true
349.785ms
0.349785ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
625.685ms
0.625685ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
150.064ms
0.150064ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false
97.1439ms
0.0971439ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
132.73ms
0.13273ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750
149.48ms
0.14948ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750
97.2409ms
0.0972409ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750
132.173ms
0.132173ms/req
1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
510.857ms
0.510857ms/req
1000 routes, 2 coordinates, no alternatives, overview=full, steps=true
350.776ms
0.350776ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
624.471ms
0.624471ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
150.867ms
0.150867ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false
97.0311ms
0.0970311ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
131.516ms
0.131516ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750
150.489ms
0.150489ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750
96.9338ms
0.0969338ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750
131.62ms
0.13162ms/req
route_mld 1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
638.024ms
0.638024ms/req
1000 routes, 2 coordinates, no alternatives, overview=full, steps=true
437.046ms
0.437046ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
810.722ms
0.810722ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
268.606ms
0.268606ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false
162.358ms
0.162358ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
292.753ms
0.292753ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750
268.794ms
0.268794ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750
162.134ms
0.162134ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750
293.145ms
0.293145ms/req
1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
646.06ms
0.64606ms/req
1000 routes, 2 coordinates, no alternatives, overview=full, steps=true
436.853ms
0.436853ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
812.85ms
0.81285ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
268.441ms
0.268441ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false
162.694ms
0.162694ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
287.822ms
0.287822ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750
265.668ms
0.265668ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750
161.826ms
0.161826ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750
287.595ms
0.287595ms/req
rtree 1 result:
207.791ms -> 0.0207791 ms/query
10 results:
242.731ms -> 0.0242731 ms/query
1 result:
206.85ms -> 0.020685 ms/query
10 results:
241.899ms -> 0.0241899 ms/query

@SiarheiFedartsou SiarheiFedartsou marked this pull request as ready for review June 7, 2024 20:24
@SiarheiFedartsou SiarheiFedartsou merged commit 8fd8d0c into master Jun 8, 2024
20 of 21 checks passed
@SiarheiFedartsou SiarheiFedartsou deleted the sf-clang-tidy-fix branch June 8, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants