Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated warnings #6894

Merged
merged 5 commits into from
May 23, 2024
Merged

Remove outdated warnings #6894

merged 5 commits into from
May 23, 2024

Conversation

DennisOSRM
Copy link
Collaborator

@DennisOSRM DennisOSRM commented May 23, 2024

Issue

The no warning settings have become outdated.

cc1plus: note: unrecognized command-line option ‘-Wno-shorten-64-to-32’ may have been intended to silence earlier diagnostics
cc1plus: note: unrecognized command-line option ‘-Wno-unused-member-function’ may have been intended to silence earlier diagnostics
cc1plus: note: unrecognized command-line option ‘-Wno-implicit-float-conversion’ may have been intended to silence earlier diagnostics
cc1plus: note: unrecognized command-line option ‘-Wno-implicit-int-conversion’ may have been intended to silence earlier diagnostics

Benchmark Results

Benchmark Base PR
alias aliased u32: 1088.9
plain u32: 1094.37
aliased double: 954.818
plain double: 952.287
aliased u32: 1080.74
plain u32: 1080.86
aliased double: 940.798
plain double: 948.737
json-render String: 8.39944ms
Stringstream: 11.7702ms
Vector: 7.59087ms
String: 8.47566ms
Stringstream: 11.8241ms
Vector: 7.61138ms
match_ch Default radius:
4.48361ms/req at 82 coordinate
0.0546781ms/coordinate
Radius 5m:
4.46375ms/req at 82 coordinate
0.054436ms/coordinate
Radius 10m:
15.274ms/req at 82 coordinate
0.186268ms/coordinate
Radius 15m:
37.176ms/req at 82 coordinate
0.453366ms/coordinate
Radius 30m:
315.754ms/req at 82 coordinate
3.85066ms/coordinate
Default radius:
4.48168ms/req at 82 coordinate
0.0546547ms/coordinate
Radius 5m:
4.44683ms/req at 82 coordinate
0.0542297ms/coordinate
Radius 10m:
15.1663ms/req at 82 coordinate
0.184954ms/coordinate
Radius 15m:
37.1405ms/req at 82 coordinate
0.452933ms/coordinate
Radius 30m:
313.781ms/req at 82 coordinate
3.8266ms/coordinate
match_mld Default radius:
3.45143ms/req at 82 coordinate
0.0420907ms/coordinate
Radius 5m:
3.43708ms/req at 82 coordinate
0.0419156ms/coordinate
Radius 10m:
12.4145ms/req at 82 coordinate
0.151396ms/coordinate
Radius 15m:
31.8435ms/req at 82 coordinate
0.388335ms/coordinate
Radius 30m:
355.008ms/req at 82 coordinate
4.32936ms/coordinate
Default radius:
3.37035ms/req at 82 coordinate
0.0411019ms/coordinate
Radius 5m:
3.35458ms/req at 82 coordinate
0.0409095ms/coordinate
Radius 10m:
12.3371ms/req at 82 coordinate
0.150452ms/coordinate
Radius 15m:
31.8716ms/req at 82 coordinate
0.388678ms/coordinate
Radius 30m:
352.352ms/req at 82 coordinate
4.29697ms/coordinate
packedvector random write:
std::vector 10465.7 ms
util::packed_vector 82037.9 ms
slowdown: 7.83874
random read:
std::vector 8428.56 ms
util::packed_vector 32889.1 ms
slowdown: 3.9021
random write:
std::vector 9702.51 ms
util::packed_vector 73755.9 ms
slowdown: 7.60173
random read:
std::vector 8368.22 ms
util::packed_vector 30225.7 ms
slowdown: 3.61196
route_ch 1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
598.507ms
0.598507ms/req
1000 routes, 2 coordinates, no alternatives, overview=full, steps=true
376.315ms
0.376315ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
757.937ms
0.757937ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
152.07ms
0.15207ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false
96.7528ms
0.0967528ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
134.199ms
0.134199ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750
150.686ms
0.150686ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750
96.5346ms
0.0965346ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750
133.009ms
0.133009ms/req
1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
596.313ms
0.596313ms/req
1000 routes, 2 coordinates, no alternatives, overview=full, steps=true
375.496ms
0.375496ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
757.985ms
0.757985ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
153.084ms
0.153084ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false
98.4702ms
0.0984702ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
133.543ms
0.133543ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750
151.211ms
0.151211ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750
97.8749ms
0.0978749ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750
133.784ms
0.133784ms/req
route_mld 1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
729.415ms
0.729415ms/req
1000 routes, 2 coordinates, no alternatives, overview=full, steps=true
461.985ms
0.461985ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
939.481ms
0.939481ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
275.042ms
0.275042ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false
160.646ms
0.160646ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
286.759ms
0.286759ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750
271.89ms
0.27189ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750
160.312ms
0.160312ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750
286.314ms
0.286314ms/req
1000 routes, 3 coordinates, no alternatives, overview=full, steps=true
721.265ms
0.721265ms/req
1000 routes, 2 coordinates, no alternatives, overview=full, steps=true
459.617ms
0.459617ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true
935.905ms
0.935905ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false
266.621ms
0.266621ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false
161.579ms
0.161579ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false
286.558ms
0.286558ms/req
1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750
266.104ms
0.266104ms/req
1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750
160.24ms
0.16024ms/req
1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750
288.362ms
0.288362ms/req
rtree 1 result:
206.655ms -> 0.0206655 ms/query
10 results:
241.654ms -> 0.0241654 ms/query
1 result:
206.761ms -> 0.0206761 ms/query
10 results:
242.589ms -> 0.0242589 ms/query

@@ -50,9 +50,7 @@ add_warning(all)
add_warning(extra)
add_warning(pedantic)
add_warning(error) # treat all warnings as errors
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DennisOSRM DennisOSRM marked this pull request as ready for review May 23, 2024 15:32
@DennisOSRM DennisOSRM merged commit 24646aa into master May 23, 2024
21 checks passed
@DennisOSRM DennisOSRM deleted the cleanup_warnings branch May 23, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants