Optimise path distance calculation in MLD map matching #6876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiarheiFedartsou
force-pushed
the
sf-optimise-map-matching
branch
from
9456fb3 to
25019cf
Compare
| @@ -650,11 +650,38 @@ double getNetworkDistance(SearchEngineData<Algorithm> &engine_working_data, | |||
| return std::numeric_limits<double>::max(); | |||
| } | |||
|
|
|||
| std::vector<PathData> unpacked_path; | |||
| BOOST_ASSERT(unpacked_nodes.size() >= 1); | |||
There was a problem hiding this comment.
I believe we could do similar optimisation for CH, but let's go step by step...
There was a problem hiding this comment.
For my understanding, there are two changes?
- Remove unnecessary annotations irrelevant to distance calculation.
- Use pre-calculated distances
There was a problem hiding this comment.
Yes, I think so
There was a problem hiding this comment.
Actually I think we can make much deeper optimization here: use 1 to N routing algorithm in map matching instead of running getNetworkDistance N times, but let's go with small steps...
mjjbell
approved these changes
May 11, 2024
| @@ -650,11 +650,38 @@ double getNetworkDistance(SearchEngineData<Algorithm> &engine_working_data, | |||
| return std::numeric_limits<double>::max(); | |||
| } | |||
|
|
|||
| std::vector<PathData> unpacked_path; | |||
| BOOST_ASSERT(unpacked_nodes.size() >= 1); | |||
There was a problem hiding this comment.
For my understanding, there are two changes?
- Remove unnecessary annotations irrelevant to distance calculation.
- Use pre-calculated distances
Co-authored-by: Michael Bell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Benchmark
I used this benchmark - it is the best what we have now :)
Before
After
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?