Upgrade clang-format to version 15 #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 14 is the version available on ubuntu-latest in Github actions
| @@ -88,7 +88,7 @@ jobs: | |||
| - name: Prepare environment | |||
| run: | | |||
| npm ci --ignore-scripts | |||
| clang-format-10 --version | |||
There was a problem hiding this comment.
It seems ubuntu-22.04 has clang-format-15. May be worth updating to it as we have to reformat a lot of files anyway? https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md
Btw 24.04 seems to be already available as well…
There was a problem hiding this comment.
Oh great, then I'll amend this PR to go straight to 24.04.
There was a problem hiding this comment.
I made this conclusion from existence of https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md, so not sure it is available in reality :)
There was a problem hiding this comment.
It seems that 24.04 based runners are not available yet. Sticking to 22.04 for now.
SiarheiFedartsou
approved these changes
May 6, 2024
DennisOSRM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 14 is the version available on ubuntu-latest in Github actions