Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for NodeJS <= v16 #6857

Merged
merged 5 commits into from
May 5, 2024
Merged

Drop support for NodeJS <= v16 #6857

merged 5 commits into from
May 5, 2024

Conversation

DennisOSRM
Copy link
Collaborator

@DennisOSRM DennisOSRM commented May 5, 2024 •
edited
Loading

duplicate of #6855 from personal fork. Codecov has been disabled temporarily since it does not seem to work anymore.

@DennisOSRM DennisOSRM changed the title Upgrade js dependencies Drop support for NodeJS <= v16 May 5, 2024
@DennisOSRM DennisOSRM requested a review from mjjbell May 5, 2024 14:22
@DennisOSRM DennisOSRM requested a review from jcoupey May 5, 2024 14:48
@DennisOSRM
Copy link
Collaborator Author

It seems the issue with codecov not working is perhaps wide spread: codecov/engineering-team#1574

@mjjbell
Copy link
Member

mjjbell commented May 5, 2024

It seems the issue with codecov not working is perhaps wide spread: codecov/engineering-team#1574

Looks like we're using an ancient version anyway that was sunset a couple of years ago.
https://github.com/codecov/codecov-action/blob/5ecb98a3c6b747ed38dc09f787459979aebb39be/CHANGELOG.md?plain=1#L179-L183

We can figure out an upgrade path separately.

@DennisOSRM
Copy link
Collaborator Author

It seems the issue with codecov not working is perhaps wide spread: codecov/engineering-team#1574

Looks like we're using an ancient version anyway that was sunset a couple of years ago. https://github.com/codecov/codecov-action/blob/5ecb98a3c6b747ed38dc09f787459979aebb39be/CHANGELOG.md?plain=1#L179-L183

We can figure out an upgrade path separately.

Indeed, plenty of outdated stuff to brush up 😁

@DennisOSRM DennisOSRM merged commit befd9dc into Project-OSRM:master May 5, 2024
20 checks passed
@DennisOSRM DennisOSRM deleted the upgrade_js_dependencies branch May 5, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjjbell mjjbell mjjbell approved these changes

@SiarheiFedartsou SiarheiFedartsou Awaiting requested review from SiarheiFedartsou

@jcoupey jcoupey Awaiting requested review from jcoupey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DennisOSRM @mjjbell