Add support for opposite approach request parameter #6842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjjbell
force-pushed
the
mbell/opposite_approach
branch
from
4cab282 to
1d285ad
Compare
DennisOSRM
approved these changes
Apr 3, 2024
include/engine/approach.hpp
Outdated
| @@ -36,7 +36,8 @@ namespace osrm::engine | |||
| enum class Approach : std::uint8_t | |||
| { | |||
| CURB = 0, | |||
| UNRESTRICTED = 1 | |||
| OPPOSITE = 1, | |||
There was a problem hiding this comment.
it's an enum class and it is not likely there are casts from/to integers. Yet, it might make sense to keep value assignments, i.e. to add OPPOSITE = 2.
|
Looks good, only one minor nitpick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As outlined in #5616, adding support for restricting the waypoint approach to the
oppositedirection, relative to the input coordinate.It was included in the original approaches PR (#4039), but dropped due to lack of support at the time.
This is beneficial for VRP use-cases in particular, and is a simple enough addition that I think it's worth supporting.
This PR leverages @asaveljevs changes, I've just added some additional docs and test coverage.
Tasklist
Requirements / Relations
Fixes #5616