Extract prerelease/build information from package semver #6839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only extract the major.minor.patch identifiers from the semver label stored in package.json. This leads to version information in executables to incorrectly report a release version is running on prereleases and special builds. This commit is a quickfix to extract this information and report it in version strings. CMake regex parsing is not sophisticated enough to handle the full semver regex, so we might need to explore other CMake modules if we want to strictly parse the label.
mjjbell
force-pushed
the
mbell/extract_prerelease_build_label
branch
from
1d1be16 to
83671f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently we only extract the
major.minor.patchidentifiers from the semver label stored inpackage.json.This leads to version information in executables incorrectly reporting a release version is running on prereleases and special builds.
This commit is a quickfix to extract this information and report it in version strings.
CMake regex parsing is not sophisticated enough to handle the full semver regex, so we might need to explore other CMake modules if we want to strictly parse the label.
Tasklist
Requirements / Relations
Fixes #6767