Fix operator overload on RouteParameters #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjjbell
reviewed
Aug 18, 2023
| inline RouteParameters::AnnotationsType operator|=(RouteParameters::AnnotationsType lhs, | ||
| RouteParameters::AnnotationsType rhs) | ||
| inline RouteParameters::AnnotationsType &operator|=(RouteParameters::AnnotationsType &lhs, | ||
| RouteParameters::AnnotationsType rhs) |
There was a problem hiding this comment.
Might be worth deleting this function instead. I assume given the bug that it's not in use.
There was a problem hiding this comment.
I can commit a change to remove it instead if it's preferred, but I think that given the use of the | operator, it might be more helpful to keep around fixed, since it can help when calculating the AnnotationsType (ie. able to do lhs |= rhs rather than lhs = lhs | rhs).
There was a problem hiding this comment.
Sounds good, thanks for spotting 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR targets an error in the operator overload in RouteParameters, which made the
|=operator nonfunctional.Tasklist
Requirements / Relations
There are no requirements or relations relevant to this PR.