Apply workaround for Conan installation issue on CI #6442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiarheiFedartsou
commented
Nov 4, 2022
| @@ -506,6 +506,11 @@ jobs: | |||
| - name: Install dev dependencies | |||
| run: | | |||
| python3 -m pip install conan==1.53.0 | |||
| # workaround for issue that GitHub Actions seems to not adding it to PATH after https://github.com/actions/runner-images/pull/6499 | |||
| # and that's CI cannot find conan executable installed above | |||
| if [[ "${RUNNER_OS}" == "macOS" ]]; then | |||
There was a problem hiding this comment.
I should have created an issue in https://github.com/actions/runner-images repo and I bet there is better fix in general(at least we could detect /Library/Frameworks/Python.framework/Versions/3.11 string automatically), but just want to unblock @DennisOSRM with his PRs
SiarheiFedartsou
changed the title
|
I bet it should be fixed by https://github.com/actions/runner-images/pull/6518/files |
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Seems to be related not to Conan itself, but this update of macOS image we are using https://github.com/actions/runner-images/pull/6499/files
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?