Add support for surface=metal,grass_paver,woodchips in bicyle profile #6395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiarheiFedartsou
commented
Oct 7, 2022
| @@ -178,6 +178,7 @@ function setup() | |||
| concrete = default_speed, | |||
| concrete_lanes = default_speed, | |||
| wood = 10, | |||
| metal = 10, | |||
There was a problem hiding this comment.
SiarheiFedartsou
commented
Oct 7, 2022
.github/workflows/osrm-backend.yml
Outdated
| @@ -29,7 +29,7 @@ jobs: | |||
| ENABLE_APPLE_SILICON: "OFF" | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - run: pip install conan==1.51.3 | |||
| - run: pip install conan==1.53.0 | |||
There was a problem hiding this comment.
We have something wrong with Conan again :/
mjjbell
approved these changes
Oct 10, 2022
mjjbell
reviewed
Oct 10, 2022
CHANGELOG.md
Outdated
| @@ -60,6 +60,7 @@ | |||
| - FIXED: Bump CI complete meta job to ubuntu-20.04 [#6323](https://github.com/Project-OSRM/osrm-backend/pull/6323) | |||
| - CHANGED: Node packages are now scoped by @project-osrm [#6386](https://github.com/Project-OSRM/osrm-backend/issues/6386) | |||
| - Routing: | |||
| - CHANGED: Add support for surface=metal,grass_paver,woodchips in bicyle profile. [#6395](https://github.com/Project-OSRM/osrm-backend/pull/6395) | |||
There was a problem hiding this comment.
Needs moving into the unreleased section again.
SiarheiFedartsou
force-pushed
the
sf-bicycle-surfaces
branch
from
386ab7b to
f1edb02
Compare
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Dec 23, 2022
v5.27.1
- Changes from 5.27.0
- Misc:
- FIXED: Revert back to using custom HTTP parser instead of Boost.Beast. [Project-OSRM#6407](Project-OSRM#6407)
- FIXED: Fix bug with large HTTP requests leading to Bad Request in osrm-routed. [Project-OSRM#6403](Project-OSRM#6403)
- Routing:
- CHANGED: Add support for surface=metal,grass_paver,woodchips in bicyle profile. [Project-OSRM#6395](Project-OSRM#6395)
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
closes #3682
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?