Upgrade to clang-tidy 14 #6353
Merged
Upgrade to clang-tidy 14 #6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiarheiFedartsou
force-pushed
the
sf-clang-tidy-14-2
branch
from
6d2f49d to
c83d1d9
Compare
| @@ -12,6 +12,7 @@ Checks: > | |||
| -bugprone-unhandled-self-assignment, | |||
| -bugprone-forward-declaration-namespace, | |||
| -bugprone-sizeof-expression, | |||
| -bugprone-throw-keyword-missing, | |||
There was a problem hiding this comment.
Useful, but I got false positives on static_assert in some places
| @@ -25,7 +25,7 @@ template <typename T> class DistTableWrapper | |||
| DistTableWrapper(std::vector<T> table, std::size_t number_of_nodes) | |||
| : table_(std::move(table)), number_of_nodes_(number_of_nodes) | |||
| { | |||
| BOOST_ASSERT_MSG(table.size() == 0, "table is empty"); | |||
There was a problem hiding this comment.
As I understand this assert was wrong
mjjbell
approved these changes
Aug 31, 2022
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR updates CI to use clang-tidy 14 and fixes some of new warnings.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?