Do not use deprecated Callback::Call overload in Node bindings #6318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -256,7 +256,7 @@ inline void asyncForTiles(const Nan::FunctionCallbackInfo<v8::Value> &info, | |||
| auto str_result = result.get<std::string>(); | |||
| v8::Local<v8::Value> argv[argc] = {Nan::Null(), render(str_result)}; | |||
|
|
|||
| callback->Call(argc, argv); | |||
| callback->Call(argc, argv, async_resource); | |||
There was a problem hiding this comment.
| @@ -148,7 +148,7 @@ inline void async(const Nan::FunctionCallbackInfo<v8::Value> &info, | |||
| ServiceMemFn service, | |||
| Nan::Callback *callback, | |||
| PluginParameters pluginParams_) | |||
| : Base(callback), osrm{std::move(osrm_)}, service{std::move(service)}, | |||
| : Base(callback, "osrm:async"), osrm{std::move(osrm_)}, service{std::move(service)}, | |||
There was a problem hiding this comment.
SiarheiFedartsou
changed the title
SiarheiFedartsou
force-pushed
the
sf-nan-deprecated
branch
from
7fac457 to
a3f017e
Compare
mjjbell
approved these changes
Aug 20, 2022
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Dec 18, 2022
v5.27.0
- Changes from 5.26.0
- API:
- ADDED: Add Flatbuffers support to NodeJS bindings. [Project-OSRM#6338](Project-OSRM#6338)
- CHANGED: Add `data_version` field to responses of all services. [Project-OSRM#5387](Project-OSRM#5387)
- FIXED: Use Boost.Beast to parse HTTP request. [Project-OSRM#6294](Project-OSRM#6294)
- FIXED: Fix inefficient osrm-routed connection handling [Project-OSRM#6113](https://gihub.com/Project-OSRM/osrm-backend/pull/6113)
- FIXED: Fix HTTP compression precedence [Project-OSRM#6113](Project-OSRM#6113)
- NodeJS:
- FIXED: Support `skip_waypoints` in Node bindings [Project-OSRM#6060](Project-OSRM#6060)
- Misc:
- ADDED: conanbuildinfo.json for easy reading of dependencies [Project-OSRM#6388](Project-OSRM#6388)
- CHANGED: Improve performance of JSON rendering. Fix undefined behaviour in JSON numbers formatting. [Project-OSRM#6380](Project-OSRM#6380)
- ADDED: Add timestamps for logs. [Project-OSRM#6375](Project-OSRM#6375)
- CHANGED: Improve performance of map matching via getPathDistance optimization. [Project-OSRM#6378](Project-OSRM#6378)
- CHANGED: Optimize RestrictionParser performance. [Project-OSRM#6344](Project-OSRM#6344)
- ADDED: Support floats for speed value in traffic updates CSV. [Project-OSRM#6327](Project-OSRM#6327)
- CHANGED: Use Lua 5.4 in Docker image. [Project-OSRM#6346](Project-OSRM#6346)
- CHANGED: Remove redundant nullptr check. [Project-OSRM#6326](Project-OSRM#6326)
- CHANGED: missing files list is included in exception message. [Project-OSRM#5360](Project-OSRM#5360)
- CHANGED: Do not use deprecated Callback::Call overload in Node bindings. [Project-OSRM#6318](Project-OSRM#6318)
- FIXED: Fix distance calculation consistency. [Project-OSRM#6315](Project-OSRM#6315)
- FIXED: Fix performance issue after migration to sol2 3.3.0. [Project-OSRM#6304](Project-OSRM#6304)
- CHANGED: Pass osm_node_ids by reference in osrm::updater::Updater class. [Project-OSRM#6298](Project-OSRM#6298)
- FIXED: Fix bug with reading Set values from Lua scripts. [Project-OSRM#6285](Project-OSRM#6285)
- FIXED: Bug in bicycle profile that caused exceptions if there is a highway=bicycle in the data. [Project-OSRM#6296](Project-OSRM#6296)
- FIXED: Internal refactoring of identifier types used in data facade [Project-OSRM#6044](Project-OSRM#6044)
- CHANGED: Update docs to reflect recent build and dependency changes [Project-OSRM#6383](Project-OSRM#6383)
- Build:
- REMOVED: Get rid of Mason. [Project-OSRM#6387](Project-OSRM#6387)
- CHANGED: Use clang-format from CI base image. [Project-OSRM#6391](Project-OSRM#6391)
- ADDED: Build Node bindings on Windows. [Project-OSRM#6334](Project-OSRM#6334)
- ADDED: Configure cross-compilation for Apple Silicon. [Project-OSRM#6360](Project-OSRM#6360)
- CHANGED: Use apt-get to install Clang on CI. [Project-OSRM#6345](Project-OSRM#6345)
- CHANGED: Fix TBB in case of Conan + NodeJS build. [Project-OSRM#6333](Project-OSRM#6333)
- CHANGED: Migrate to modern TBB version. [Project-OSRM#6300](Project-OSRM#6300)
- CHANGED: Enable performance-move-const-arg clang-tidy check. [Project-OSRM#6319](Project-OSRM#6319)
- CHANGED: Use the latest node on CI. [Project-OSRM#6317](Project-OSRM#6317)
- CHANGED: Migrate Windows CI to GitHub Actions. [Project-OSRM#6312](Project-OSRM#6312)
- ADDED: Add smoke test for Docker image. [Project-OSRM#6313](Project-OSRM#6313)
- CHANGED: Update libosmium to version 2.18.0. [Project-OSRM#6303](Project-OSRM#6303)
- CHANGED: Remove EXACT from find_package if using Conan. [Project-OSRM#6299](Project-OSRM#6299)
- CHANGED: Configure Undefined Behaviour Sanitizer. [Project-OSRM#6290](Project-OSRM#6290)
- CHANGED: Use Conan instead of Mason to install code dependencies. [Project-OSRM#6284](Project-OSRM#6284)
- CHANGED: Migrate to C++17. Update sol2 to 3.3.0. [Project-OSRM#6279](Project-OSRM#6279)
- CHANGED: Update macOS CI image to macos-11. [Project-OSRM#6286](Project-OSRM#6286)
- CHANGED: Enable even more clang-tidy checks. [Project-OSRM#6273](Project-OSRM#6273)
- CHANGED: Configure CMake to not build flatbuffers tests and samples. [Project-OSRM#6274](Project-OSRM#6274)
- CHANGED: Enable more clang-tidy checks. [Project-OSRM#6270](Project-OSRM#6270)
- CHANGED: Configure clang-tidy job on CI. [Project-OSRM#6261](Project-OSRM#6261)
- CHANGED: Use Github Actions for building container images [Project-OSRM#6138](Project-OSRM#6138)
- CHANGED: Upgrade Boost dependency to 1.70 [Project-OSRM#6113](Project-OSRM#6113)
- CHANGED: Upgrade Ubuntu CI builds to 20.04 [Project-OSRM#6119](Project-OSRM#6119)
- CHANGED: Make building osrm-routed optional [Project-OSRM#6144](Project-OSRM#6144)
- FIXED: Run all unit tests in CI [Project-OSRM#5248](Project-OSRM#5248)
- FIXED: Fix installation of Mason CMake and 32 bit CI build [Project-OSRM#6170](Project-OSRM#6170)
- FIXED: Fixed Node docs generation check in CI. [Project-OSRM#6058](Project-OSRM#6058)
- CHANGED: Docker build, enabled arm64 build layer [Project-OSRM#6172](Project-OSRM#6172)
- CHANGED: Docker build, enabled apt-get update/install caching in separate layer for build phase [Project-OSRM#6175](Project-OSRM#6175)
- FIXED: Bump CI complete meta job to ubuntu-20.04 [Project-OSRM#6323](Project-OSRM#6323)
- CHANGED: Node packages are now scoped by @Project-OSRM [Project-OSRM#6386](Project-OSRM#6386)
- Routing:
- CHANGED: Lazily generate optional route path data [Project-OSRM#6045](Project-OSRM#6045)
- FIXED: Completed support for no_entry and no_exit turn restrictions. [Project-OSRM#5988](Project-OSRM#5988)
- ADDED: Add support for non-round-trips with a single fixed endpoint. [Project-OSRM#6050](Project-OSRM#6050)
- FIXED: Improvements to maneuver override processing [Project-OSRM#6125](Project-OSRM#6125)
- ADDED: Support snapping to multiple ways at an input location. [Project-OSRM#5953](Project-OSRM#5953)
- FIXED: Fix snapping target locations to ways used in turn restrictions. [Project-OSRM#6339](Project-OSRM#6339)
- ADDED: Support OSM traffic signal directions. [Project-OSRM#6153](Project-OSRM#6153)
- FIXED: Ensure u-turn exists in intersection view. [Project-OSRM#6376](Project-OSRM#6376)
- FIXED: Gracefully handle no-turn intersections in guidance processing. [Project-OSRM#6382](Project-OSRM#6382)
- Profile:
- CHANGED: Bicycle surface speeds [Project-OSRM#6212](Project-OSRM#6212)
- Tools:
- CHANGED: Do not generate intermediate .osrm file in osrm-extract. [Project-OSRM#6354](Project-OSRM#6354)
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Dec 18, 2022
v5.27.0
- Changes from 5.26.0
- API:
- ADDED: Add Flatbuffers support to NodeJS bindings. [Project-OSRM#6338](Project-OSRM#6338)
- CHANGED: Add `data_version` field to responses of all services. [Project-OSRM#5387](Project-OSRM#5387)
- FIXED: Use Boost.Beast to parse HTTP request. [Project-OSRM#6294](Project-OSRM#6294)
- FIXED: Fix inefficient osrm-routed connection handling [Project-OSRM#6113](https://gihub.com/Project-OSRM/osrm-backend/pull/6113)
- FIXED: Fix HTTP compression precedence [Project-OSRM#6113](Project-OSRM#6113)
- NodeJS:
- FIXED: Support `skip_waypoints` in Node bindings [Project-OSRM#6060](Project-OSRM#6060)
- Misc:
- ADDED: conanbuildinfo.json for easy reading of dependencies [Project-OSRM#6388](Project-OSRM#6388)
- CHANGED: Improve performance of JSON rendering. Fix undefined behaviour in JSON numbers formatting. [Project-OSRM#6380](Project-OSRM#6380)
- ADDED: Add timestamps for logs. [Project-OSRM#6375](Project-OSRM#6375)
- CHANGED: Improve performance of map matching via getPathDistance optimization. [Project-OSRM#6378](Project-OSRM#6378)
- CHANGED: Optimize RestrictionParser performance. [Project-OSRM#6344](Project-OSRM#6344)
- ADDED: Support floats for speed value in traffic updates CSV. [Project-OSRM#6327](Project-OSRM#6327)
- CHANGED: Use Lua 5.4 in Docker image. [Project-OSRM#6346](Project-OSRM#6346)
- CHANGED: Remove redundant nullptr check. [Project-OSRM#6326](Project-OSRM#6326)
- CHANGED: missing files list is included in exception message. [Project-OSRM#5360](Project-OSRM#5360)
- CHANGED: Do not use deprecated Callback::Call overload in Node bindings. [Project-OSRM#6318](Project-OSRM#6318)
- FIXED: Fix distance calculation consistency. [Project-OSRM#6315](Project-OSRM#6315)
- FIXED: Fix performance issue after migration to sol2 3.3.0. [Project-OSRM#6304](Project-OSRM#6304)
- CHANGED: Pass osm_node_ids by reference in osrm::updater::Updater class. [Project-OSRM#6298](Project-OSRM#6298)
- FIXED: Fix bug with reading Set values from Lua scripts. [Project-OSRM#6285](Project-OSRM#6285)
- FIXED: Bug in bicycle profile that caused exceptions if there is a highway=bicycle in the data. [Project-OSRM#6296](Project-OSRM#6296)
- FIXED: Internal refactoring of identifier types used in data facade [Project-OSRM#6044](Project-OSRM#6044)
- CHANGED: Update docs to reflect recent build and dependency changes [Project-OSRM#6383](Project-OSRM#6383)
- Build:
- REMOVED: Get rid of Mason. [Project-OSRM#6387](Project-OSRM#6387)
- CHANGED: Use clang-format from CI base image. [Project-OSRM#6391](Project-OSRM#6391)
- ADDED: Build Node bindings on Windows. [Project-OSRM#6334](Project-OSRM#6334)
- ADDED: Configure cross-compilation for Apple Silicon. [Project-OSRM#6360](Project-OSRM#6360)
- CHANGED: Use apt-get to install Clang on CI. [Project-OSRM#6345](Project-OSRM#6345)
- CHANGED: Fix TBB in case of Conan + NodeJS build. [Project-OSRM#6333](Project-OSRM#6333)
- CHANGED: Migrate to modern TBB version. [Project-OSRM#6300](Project-OSRM#6300)
- CHANGED: Enable performance-move-const-arg clang-tidy check. [Project-OSRM#6319](Project-OSRM#6319)
- CHANGED: Use the latest node on CI. [Project-OSRM#6317](Project-OSRM#6317)
- CHANGED: Migrate Windows CI to GitHub Actions. [Project-OSRM#6312](Project-OSRM#6312)
- ADDED: Add smoke test for Docker image. [Project-OSRM#6313](Project-OSRM#6313)
- CHANGED: Update libosmium to version 2.18.0. [Project-OSRM#6303](Project-OSRM#6303)
- CHANGED: Remove EXACT from find_package if using Conan. [Project-OSRM#6299](Project-OSRM#6299)
- CHANGED: Configure Undefined Behaviour Sanitizer. [Project-OSRM#6290](Project-OSRM#6290)
- CHANGED: Use Conan instead of Mason to install code dependencies. [Project-OSRM#6284](Project-OSRM#6284)
- CHANGED: Migrate to C++17. Update sol2 to 3.3.0. [Project-OSRM#6279](Project-OSRM#6279)
- CHANGED: Update macOS CI image to macos-11. [Project-OSRM#6286](Project-OSRM#6286)
- CHANGED: Enable even more clang-tidy checks. [Project-OSRM#6273](Project-OSRM#6273)
- CHANGED: Configure CMake to not build flatbuffers tests and samples. [Project-OSRM#6274](Project-OSRM#6274)
- CHANGED: Enable more clang-tidy checks. [Project-OSRM#6270](Project-OSRM#6270)
- CHANGED: Configure clang-tidy job on CI. [Project-OSRM#6261](Project-OSRM#6261)
- CHANGED: Use Github Actions for building container images [Project-OSRM#6138](Project-OSRM#6138)
- CHANGED: Upgrade Boost dependency to 1.70 [Project-OSRM#6113](Project-OSRM#6113)
- CHANGED: Upgrade Ubuntu CI builds to 20.04 [Project-OSRM#6119](Project-OSRM#6119)
- CHANGED: Make building osrm-routed optional [Project-OSRM#6144](Project-OSRM#6144)
- FIXED: Run all unit tests in CI [Project-OSRM#5248](Project-OSRM#5248)
- FIXED: Fix installation of Mason CMake and 32 bit CI build [Project-OSRM#6170](Project-OSRM#6170)
- FIXED: Fixed Node docs generation check in CI. [Project-OSRM#6058](Project-OSRM#6058)
- CHANGED: Docker build, enabled arm64 build layer [Project-OSRM#6172](Project-OSRM#6172)
- CHANGED: Docker build, enabled apt-get update/install caching in separate layer for build phase [Project-OSRM#6175](Project-OSRM#6175)
- FIXED: Bump CI complete meta job to ubuntu-20.04 [Project-OSRM#6323](Project-OSRM#6323)
- CHANGED: Node packages are now scoped by @Project-OSRM [Project-OSRM#6386](Project-OSRM#6386)
- Routing:
- CHANGED: Lazily generate optional route path data [Project-OSRM#6045](Project-OSRM#6045)
- FIXED: Completed support for no_entry and no_exit turn restrictions. [Project-OSRM#5988](Project-OSRM#5988)
- ADDED: Add support for non-round-trips with a single fixed endpoint. [Project-OSRM#6050](Project-OSRM#6050)
- FIXED: Improvements to maneuver override processing [Project-OSRM#6125](Project-OSRM#6125)
- ADDED: Support snapping to multiple ways at an input location. [Project-OSRM#5953](Project-OSRM#5953)
- FIXED: Fix snapping target locations to ways used in turn restrictions. [Project-OSRM#6339](Project-OSRM#6339)
- ADDED: Support OSM traffic signal directions. [Project-OSRM#6153](Project-OSRM#6153)
- FIXED: Ensure u-turn exists in intersection view. [Project-OSRM#6376](Project-OSRM#6376)
- FIXED: Gracefully handle no-turn intersections in guidance processing. [Project-OSRM#6382](Project-OSRM#6382)
- Profile:
- CHANGED: Bicycle surface speeds [Project-OSRM#6212](Project-OSRM#6212)
- Tools:
- CHANGED: Do not generate intermediate .osrm file in osrm-extract. [Project-OSRM#6354](Project-OSRM#6354)
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Noticed that we use deprecated overload of this method.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?