Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the URL parser for special chars in profile #6090

Merged
merged 4 commits into from
Sep 3, 2021

Conversation

TheMarex
Copy link
Member

Issue

The URLs used for osrm-routed have the form {service}/{version}/{profile}/{params}?{options...}. The boost spirit grammar for parsing the profile and service identifiers was artificially limited to only allow alpha-numerical characters, but any URL-safe character would be fine.

This PR additionally allows for ._-~.

Tasklist

@TheMarex TheMarex requested a review from mjjbell July 27, 2021 14:27
@TheMarex TheMarex requested a review from mjjbell August 27, 2021 10:36
@TheMarex
Copy link
Member Author

Updated the grammar. Thanks for the review @mjjbell I learned something about boost spirit again (and why I don't like it) 😆

@mjjbell
Copy link
Member

mjjbell commented Aug 28, 2021

@TheMarex one minor change left to prevent a regression.

(Ideally it would be picked up by CI but the Travis integration is broken - if you have some time, take a look at #6071 which uses Github Actions as a drop-in replacement)

Copy link
Member

@mjjbell mjjbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change to prevent regression.

Copy link
Member

@mjjbell mjjbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TheMarex TheMarex merged commit 155ca8b into master Sep 3, 2021
@TheMarex TheMarex deleted the patrick/fix_routed_url_parser branch September 3, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants