-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the URL parser for special chars in profile #6090
Conversation
Updated the grammar. Thanks for the review @mjjbell I learned something about boost spirit again (and why I don't like it) 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change to prevent regression.
Co-authored-by: Michael Bell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Issue
The URLs used for
osrm-routed
have the form{service}/{version}/{profile}/{params}?{options...}
. The boost spirit grammar for parsing theprofile
andservice
identifiers was artificially limited to only allow alpha-numerical characters, but any URL-safe character would be fine.This PR additionally allows for
._-~
.Tasklist